New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

failed deferred transactions were in history (6214) #6220

Merged
merged 2 commits into from Nov 2, 2018

Conversation

Projects
None yet
3 participants
@tbfleming
Contributor

tbfleming commented Nov 2, 2018

Change Description

The history plugin sometimes included failed deferred transactions in its history. Since it doesn't store receipt status, there wasn't a reliable way for users of the history API to know which actions were executed. #6214

As a reminder, the history plugin is deprecated. This fix is included because the bug opens an attack vector against apps which rely on data from the history plugin to make decisions.

Documentation Additions

This is a behavior change. Previously get_transaction could retrieve failed or expired deferred transactions.

@tbfleming tbfleming changed the base branch from master to release/1.4.x Nov 2, 2018

@heifner

heifner approved these changes Nov 2, 2018

@jgiszczak jgiszczak referenced this pull request Nov 2, 2018

Closed

get transaction error #5795

Show resolved Hide resolved plugins/history_plugin/history_plugin.cpp Outdated
@arhag

arhag approved these changes Nov 2, 2018

@tbfleming tbfleming merged commit e0cb96c into release/1.4.x Nov 2, 2018

20 checks passed

buildkite/eosio Build #5394 passed (32 minutes, 32 seconds)
Details
buildkite/eosio/aws-build Passed (10 minutes, 8 seconds)
Details
buildkite/eosio/aws-np-tests Passed (11 minutes, 9 seconds)
Details
buildkite/eosio/aws-tests Passed (10 minutes, 23 seconds)
Details
buildkite/eosio/centos-build Passed (13 minutes, 3 seconds)
Details
buildkite/eosio/centos-np-tests Passed (11 minutes, 17 seconds)
Details
buildkite/eosio/centos-tests Passed (7 minutes, 11 seconds)
Details
buildkite/eosio/darwin-build Passed (8 minutes, 57 seconds)
Details
buildkite/eosio/darwin-np-tests Passed (19 minutes, 11 seconds)
Details
buildkite/eosio/darwin-tests Passed (9 minutes, 4 seconds)
Details
buildkite/eosio/fedora-build Passed (11 minutes, 37 seconds)
Details
buildkite/eosio/fedora-np-tests Passed (11 minutes, 36 seconds)
Details
buildkite/eosio/fedora-tests Passed (9 minutes, 54 seconds)
Details
buildkite/eosio/pipeline Passed (4 seconds)
Details
buildkite/eosio/ubuntu-18-dot-04-build Passed (7 minutes, 27 seconds)
Details
buildkite/eosio/ubuntu-18-dot-04-np-tests Passed (10 minutes, 5 seconds)
Details
buildkite/eosio/ubuntu-18-dot-04-tests Passed (7 minutes, 7 seconds)
Details
buildkite/eosio/ubuntu-build Passed (9 minutes, 16 seconds)
Details
buildkite/eosio/ubuntu-np-tests Passed (10 minutes, 27 seconds)
Details
buildkite/eosio/ubuntu-tests Passed (7 minutes, 30 seconds)
Details

@tbfleming tbfleming deleted the fix-history-deferred branch Nov 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment