New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return 400 on get_block with nonexist block number [Issue 6374] #6490

Merged
merged 1 commit into from Dec 18, 2018

Conversation

Projects
None yet
4 participants
@necokeine
Copy link
Contributor

necokeine commented Dec 17, 2018

Return 404 on get_block with uonexist block number.

Resolves #6374

Change Description

Consensus Changes

API Changes

Documentation Additions

@heifner heifner changed the base branch from master to develop Dec 17, 2018

Show resolved Hide resolved plugins/http_plugin/http_plugin.cpp Outdated

@necokeine necokeine force-pushed the necokeine:necokeine branch from 5cfd3ce to 66fd779 Dec 18, 2018

@necokeine necokeine changed the title Return 404 on get_block with nonexist block number [Issue 6374] Return 400 on get_block with nonexist block number [Issue 6374] Dec 18, 2018

@necokeine

This comment has been minimized.

Copy link
Contributor Author

necokeine commented Dec 18, 2018

Thank you for review this code, it is my first time to send a merge request on Github. I have several questions here.

  1. Shall I develop on master thread directly? or something else.
  2. Shall I follow some code style here?
@heifner

This comment has been minimized.

Copy link
Contributor

heifner commented Dec 18, 2018

@necokeine Please develop on develop unless it is a bug fix for a specific version.
Please follow the code style you find in the files you are modifying.
Thanks for your contributions.

@wanderingbort wanderingbort merged commit d54a0e2 into EOSIO:develop Dec 18, 2018

29 checks passed

buildkite/eosio Build #6838 passed (42 minutes, 24 seconds)
Details
buildkite/eosio/aws-build Passed (8 minutes, 36 seconds)
Details
buildkite/eosio/aws-np-tests Passed (12 minutes, 10 seconds)
Details
buildkite/eosio/aws-tests Passed (3 minutes, 59 seconds)
Details
buildkite/eosio/centos-build Passed (14 minutes, 38 seconds)
Details
buildkite/eosio/centos-np-tests Passed (11 minutes, 30 seconds)
Details
buildkite/eosio/centos-package-builder Passed (2 minutes, 12 seconds)
Details
buildkite/eosio/centos-tests Passed (4 minutes, 36 seconds)
Details
buildkite/eosio/darwin-high-sierra-build Passed (8 minutes, 29 seconds)
Details
buildkite/eosio/darwin-high-sierra-np-tests Passed (19 minutes, 45 seconds)
Details
buildkite/eosio/darwin-high-sierra-package-builder Passed (35 seconds)
Details
buildkite/eosio/darwin-high-sierra-tests Passed (4 minutes, 42 seconds)
Details
buildkite/eosio/darwin-mojave-build Passed (6 minutes, 49 seconds)
Details
buildkite/eosio/darwin-mojave-np-tests Passed (18 minutes, 43 seconds)
Details
buildkite/eosio/darwin-mojave-package-builder Passed (33 seconds)
Details
buildkite/eosio/darwin-mojave-tests Passed (4 minutes, 8 seconds)
Details
buildkite/eosio/fedora-build Passed (8 minutes, 28 seconds)
Details
buildkite/eosio/fedora-np-tests Passed (11 minutes, 4 seconds)
Details
buildkite/eosio/fedora-package-builder Passed (1 minute, 32 seconds)
Details
buildkite/eosio/fedora-tests Passed (4 minutes, 20 seconds)
Details
buildkite/eosio/pipeline Passed (8 seconds)
Details
buildkite/eosio/ubuntu-18-dot-04-build Passed (5 minutes, 42 seconds)
Details
buildkite/eosio/ubuntu-18-dot-04-np-tests Passed (11 minutes, 6 seconds)
Details
buildkite/eosio/ubuntu-18-dot-04-package-builder Passed (34 seconds)
Details
buildkite/eosio/ubuntu-18-dot-04-tests Passed (4 minutes, 28 seconds)
Details
buildkite/eosio/ubuntu-build Passed (6 minutes)
Details
buildkite/eosio/ubuntu-np-tests Passed (11 minutes, 29 seconds)
Details
buildkite/eosio/ubuntu-package-builder Passed (1 minute, 32 seconds)
Details
buildkite/eosio/ubuntu-tests Passed (4 minutes, 39 seconds)
Details

@necokeine necokeine deleted the necokeine:necokeine branch Dec 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment