Net plugin sync #7854

heifner · 2019-09-05T17:48:13Z

Change Description

This PR contains a few fixes that all together brings stability to the nodeos startup catchup test nodeos_startup_catchup_lr_test.
Removed block_while_syncing_with_other_peer as there was a race condition with it working correctly and it provides no value.
Removed a unless lock and moved a set_state() to after determination instead of setting it and then setting it back. This particular change would have no affect for single-threaded, but multi-threaded can see it in in_sync temporarily.
Moved the recording of connection fork_head & fork_head_num after we have determined we are not in lib_catchup as setting this when in lib catchup and returning sets up condition where subsequent calls would see the change and not send a catchup request.
-- This particular change is a candidate for release/1.7.x and release/1.8.x.

…termination

…ks around atomic set_state()

…_num if in lib_catchup.

heifner added 8 commits September 4, 2019 08:40

Switch to head_catchup instead of in_sync from lib_catchup

ce1bc14

Add debug of handle signed block message. Fixed lambda.

bc17197

Remove syncing with other peer check as there is race condition on de…

843329a

…termination

Revert switch to head_catchup instead of in_sync. Remove unneeded loc…

31a7d24

…ks around atomic set_state()

Do not switch to in_sync until in_sync

9e658ca

Revert in_sync change as logic depends on it. Do not update fork_head…

7270b5c

…_num if in lib_catchup.

Remove unused method block_while_syncing_with_other_peer

959789c

Merge branch 'develop' into net-plugin-catchup

5ff85fc

brianjohnson5972 approved these changes Sep 5, 2019

View reviewed changes

heifner merged commit 815477e into develop Sep 5, 2019

arhag deleted the net-plugin-catchup branch September 5, 2019 23:07