New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix detection of controller events with deCONZ #44
Conversation
Hi @eloo, Thanks! |
Hi @EPMatt Thanks a lot |
@EPMatt like this
|
@eloo I took some time to better understand why the fix does not work. I think the issue is in how Home Assistant renders variables in the I don't know whether this is an expected behaviour, but I'm now opening an issue on HA Core to report the problem. Thank you very much for your test, that pointed me in the right direction. :) |
Hi @eloo, Thanks! |
@EPMatt okay yes, an implicit type conversion sounds also unexpected to me. i will give your fix a try in the evening. Thanks! |
@EPMatt thanks |
Hi @eloo, Thank you for your feedback, I'm happy to hear that your issue is solved. :) Thanks again! |
…ith deCONZ (#44) * fix detection of controller events with deconz * force convert trigger_action to string * remove useless jinja filter * update changelog
Hi there, 🔒 This pull request has been automatically locked since there has not been any recent activity after it was closed. Thanks! |
Thank you for taking the time to work on a Pull Request. Your contribution is really appreciated! 🎉
Please don't delete any part of the template, since keeping the provided structure will help maintainers to review your work more rapidly.
Sections marked as * are required and need to be filled in.
Proposed change*
Fix detection of controller events with deCONZ. This preserves the fix for double press events introduced in previous updates.
It works by converting
deconz_event
events payload into strings, ensuring all RAW events comparisons within the blueprint are valid and always involve twostring
operands.Closes #42.
Checklist*
npm run format
before submitting my Pull Request.