Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2HB animation resembles 2HS #884

Closed
Isaaru opened this issue Aug 14, 2019 · 6 comments
Closed

2HB animation resembles 2HS #884

Isaaru opened this issue Aug 14, 2019 · 6 comments

Comments

@Isaaru
Copy link
Contributor

Isaaru commented Aug 14, 2019

case EQEmu::item::ItemType2HBlunt: // 2H Blunt
			skillinuse = EQEmu::skills::Skill2HBlunt;
			type = anim2HSlashing; //anim2HWeapon
			break;

and

case EQEmu::skills::Skill2HBlunt: // 2H Blunt
			type = anim2HSlashing; //anim2HWeapon
			break;
@dencelle
Copy link
Contributor

case EQEmu::item::ItemType2HSlash: // 2H Slashing

just so this is a bit easier to reference, although, i'm not exactly sure what animation id 2hb weapons should have

@Isaaru
Copy link
Contributor Author

Isaaru commented Aug 14, 2019

anim2HWeapon

@dencelle
Copy link
Contributor

3ec1c89
this is when it was changed from anim2HWeapon to anim2HSlashing... so, we have @Isaaru saying it should be one thing and @ukmeth0d saying it should be another...

@Isaaru
Copy link
Contributor Author

Isaaru commented Sep 26, 2019

I propose simply making a rule for this. Allow the server owners to choose original 2hb animation or the 2hs style.

@prestanneth
Copy link
Contributor

animation 4 (2hb) is the same as 2 piercing under new models which is a piercing animation visually.
(hence why it was changed to 5 above when really it was making an assumption on user preferences)

If you swap models (under options before logging into game), to turn off luclin models, 2hb becomes
the proper 2hnd blunt whack visually which is more correct than
the downwards slash that is live on emu today when new models are on.
( If you reverse the above change first that is )

So, essentially this is not server based but client based, more specifically user preference based on a per race basis.

The main issue with the code is, its not checking what models are loaded to select the correct animation and just assuming everyone uses new models only.

@Isaaru
Copy link
Contributor Author

Isaaru commented Nov 21, 2019

I don't use new models and never have.
This can be closed. I made the change on my end already.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants