New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
On 32-bit platforms libatomic should be linked to #1294
Comments
|
Please would you let us know what you were trying to do rather than just sending us a dump of output |
@jajhall Thank you for responding. I was building Ideally configure stage should implement a test for hardware support for 8-byte atomics, if it fails without As an example, see: https://github.com/facebook/rocksdb/blob/5fc57eec2b44337289f25c1b5687beb54ad709a2/CMakeLists.txt#L296-L312 |
|
I'll see what we can do, but support for 32-bit architectures is very low priority |
Thank you. I am not asking to dedicate time to specifically support 32-bit platforms, but libatomic linking is trivial to add, and that will be a definite improvement. |
|
P. S. I can actually take care of that, let me first ensure everything builds and tests pass. |
|
@jajhall Sorry, been a bit busy. I have built |
|
@galabovaa Can the CMake patch in the link be incorporated? |
|
Yes, the patch just needs to be modified to not require C++ 17 and we can add it to CMake. I will do that |
|
@galabovaa Has this been done, as of 1.5.3? |
df73034 adds a conditional |
|
@HaoZeke Thank you, I will test it. |
Actually for 32-bit systems and the meson build, it is better to use #1460 and build with |
|
@HaoZeke We built it with CMake: https://ports.macports.org/port/HiGHS/details Do we need some special config options in that case? (I would rather not switch to P. S. Sorry, did not check it right-away when replied above. |
That's alright, I from a quick look, it seems like |
|
'HIGHSINT64' will always be off by default |
|
Is this fixed? |
Should be closed by #1603. |
|
Closed by #1603 |
Not yet sure about remaining errors, possibly
gcc12bug (at least thatnon_lazy_ptrthing).The text was updated successfully, but these errors were encountered: