From f439052fefb63edcc4ed7388bcbfa49cdb47d927 Mon Sep 17 00:00:00 2001 From: Erik Kluzek Date: Tue, 7 Apr 2020 12:02:03 -0600 Subject: [PATCH 1/7] Fix Python3 problem in SSP fixes #974 --- cime_config/SystemTests/ssp.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cime_config/SystemTests/ssp.py b/cime_config/SystemTests/ssp.py index a2aacc9e43..4b740a5694 100644 --- a/cime_config/SystemTests/ssp.py +++ b/cime_config/SystemTests/ssp.py @@ -41,7 +41,7 @@ def run_phase(self): # determine run lengths needed below stop_nf = self._case.get_value("STOP_N") - stop_n1 = stop_nf / 2 + stop_n1 = int(stop_nf / 2) stop_n2 = stop_nf - stop_n1 #------------------------------------------------------------------- From 59e5505c36d7cebc24511e11b2a2bf127dd98ce6 Mon Sep 17 00:00:00 2001 From: Erik Kluzek Date: Mon, 13 Apr 2020 22:57:03 -0600 Subject: [PATCH 2/7] Use the zero percent urban file when sim_year=PtVg, this requires putting the finding of the file inside the sim_year loop --- .../namelist_defaults_clm4_5_tools.xml | 3 ++ tools/mksurfdata_map/mksurfdata.pl | 36 ++++++++++++------- 2 files changed, 26 insertions(+), 13 deletions(-) diff --git a/bld/namelist_files/namelist_defaults_clm4_5_tools.xml b/bld/namelist_files/namelist_defaults_clm4_5_tools.xml index 3c35256d01..829f2ca2e6 100644 --- a/bld/namelist_files/namelist_defaults_clm4_5_tools.xml +++ b/bld/namelist_files/namelist_defaults_clm4_5_tools.xml @@ -257,6 +257,9 @@ attributes from the config_cache.xml file (with keys converted to upper-case). lnd/clm2/rawdata/mksrf_urban_0.05x0.05_simyr2000.c120621.nc +lnd/clm2/rawdata/mksrf_urban_0.05x0.05_zerourbanpct.c181014.nc + lnd/clm2/rawdata/mksrf_gdp_0.5x0.5_AVHRR_simyr2000.c130228.nc +lnd/clm2/rawdata/mksrf_gdp_0.5x0_zerogdp.c200413.nc lnd/clm2/rawdata/mksrf_peatf_0.5x0.5_AVHRR_simyr2000.c130228.nc @@ -298,6 +300,9 @@ attributes from the config_cache.xml file (with keys converted to upper-case). lnd/clm2/rawdata/mksrf_abm_0.5x0.5_AVHRR_simyr2000.c130201.nc +lnd/clm2/rawdata/mksrf_abm_0.5x0.5_missingabm.c200413.nc + lnd/clm2/rawdata/mksrf_topostats_1km-merge-10min_HYDRO1K-merge-nomask_simyr2000.c130402.nc From a37cb857c9165e8841809570fdd45d1b66db44b3 Mon Sep 17 00:00:00 2001 From: Erik Kluzek Date: Mon, 20 Apr 2020 11:35:36 -0600 Subject: [PATCH 4/7] Update change files --- doc/ChangeSum | 1 + doc/release-clm5.0.ChangeLog | 81 ++++++++++++++++++++++++++++++++++++ 2 files changed, 82 insertions(+) diff --git a/doc/ChangeSum b/doc/ChangeSum index b0857917b4..ae49702e70 100644 --- a/doc/ChangeSum +++ b/doc/ChangeSum @@ -1,5 +1,6 @@ Tag Who Date Summary ============================================================================================================================ +release-clm5.0.34 erik 04/20/2020 Update documentation for release-clm5.0 branch, and fix issues with no-anthro surface dataset creation release-clm5.0.33 erik 04/07/2020 Turn irrigation on for 2300 SSP extensions release-clm5.0.32 erik 04/02/2020 Extensions to 2300 for SSP5-8.5,SSP5-3.4, and SSP1-2.6 release-clm5.0.31 erik 03/29/2020 Bring in raw datasets for 2100-2300 extension for SSP5-8.5/3.5 and SSP1-2.6, some other misc. changes diff --git a/doc/release-clm5.0.ChangeLog b/doc/release-clm5.0.ChangeLog index 06bccbf9e4..a1b23f3162 100644 --- a/doc/release-clm5.0.ChangeLog +++ b/doc/release-clm5.0.ChangeLog @@ -1,4 +1,85 @@ =============================================================== +Tag name: release-clm5.0.34 +Originator(s): erik (Erik Kluzek,UCAR/TSS,303-497-1326) +Date: Mon Apr 20 11:27:34 MDT 2020 +One-line Summary: Update documentation for release-clm5.0 branch, and fix issues with no-anthro surface dataset creation + +Purpose of this version: +------------------------ + +Fix the issues with the no-anthro surface dataset creation (the PtVg simulation year). This +makes sure GDP and urban is set to zero and abm to missing for this case. Also bring in the python3 +fix that was intended for the last release tag. + +CTSM Master Tag This Corresponds To: ctsm1.0.dev025 (with many other changes) + +Summary of changes: +------------------- + +Issues fixed (include CTSM Issue #): #980 #974 + Fixes #980 -- PtVg option to mksurfdata should also set urban, and GDP to zero, as well as abm to missing + Fixes #974 -- Python 3 problem in SSP test + +Science changes since: release-clm5.0.33 + For Potential vegetation sim_year set urban to zero, GDP to zero and abm to missing with mksurfdata.pl + +Software changes since: release-clm5.0.33 + Fix python3 issue for testing in ssp.py + +Changes to User Interface since: release-clm5.0.33 + +Testing: +-------- + + [PASS means all tests PASS and OK means tests PASS other than expected fails.] + + build-namelist tests: + + cheyenne - PASS + + unit-tests (components/clm/src): + + cheyenne - PASS + izumi ---- PASS + + tools-tests (components/clm/test/tools): + + cheyenne - OK + izumi ---- OK + + PTCLM testing (components/clm/tools/shared/PTCLM/test): None + + regular tests (aux_clm): None + +Summary of Answer changes: +------------------------- + +If the tag used for baseline comparisons was NOT the previous tag, note that here: previous + +Changes answers relative to baseline: No bit-for-bit (other than PtVg surface dataset creation) + +Detailed list of changes: +------------------------ + +Externals being used: No updates + + cism: cism-release-cesm2.1.2_04 + rtm: release-cesm2.0.04 + mosart: release-cesm2.0.04 + cime: cim5.6.33 + FATES: sci.1.30.0_api.8.0.0 + PTCLM: PTCLM2_20200121 + +CTSM Tag versions pulled over from master development branch: None + +Pull Requests that document the changes (include PR ids): #976 #986 +(https://github.com/ESCOMP/ctsm/pull) + + #976 -- bring documentation to release branch + #986 -- Fix issues with no-atnthro surface dataset creation + +=============================================================== +=============================================================== Tag name: release-clm5.0.33 Originator(s): erik (Erik Kluzek) Date: Tue Apr 7 13:21:28 MDT 2020 From a2bc69731efed5962f46c0dd7f8aba6a005a4fdb Mon Sep 17 00:00:00 2001 From: Erik Kluzek Date: Mon, 20 Apr 2020 11:57:30 -0600 Subject: [PATCH 5/7] Add mksrfdt_f09_PtVg test --- test/tools/README.testnames | 15 ++++++++------- test/tools/input_tests_master | 3 +++ test/tools/nl_files/mksrfdt_f09_PtVg | 1 + test/tools/tests_pretag_cheyenne_nompi | 1 + 4 files changed, 13 insertions(+), 7 deletions(-) create mode 100644 test/tools/nl_files/mksrfdt_f09_PtVg diff --git a/test/tools/README.testnames b/test/tools/README.testnames index 2795a14f0a..eb6d50f38c 100644 --- a/test/tools/README.testnames +++ b/test/tools/README.testnames @@ -24,16 +24,17 @@ n is the configuration type: 0 -- unused a -- unused b -- unused -c -- mkprocdata_map clm4.5 -d -- mkmapgrids clm4.5 -e -- gen_domain clm4.5 -f -- PTCLM clm4.5 -g -- mksurfdata_map clm4.5 -h -- interpinic clm4.5 -i -- tools scripts clm4.5 +c -- mkprocdata_map clm5.0 +d -- mkmapgrids clm5.0 +e -- gen_domain clm5.0 +f -- PTCLM clm5.0 +g -- mksurfdata_map clm5.0 +h -- interpinic clm5.0 +i -- tools scripts clm5.0 m is the resolution +0 -- 0.9x1.25 1 -- 48x96 5 -- 10x15 6 -- 5x5_amazon diff --git a/test/tools/input_tests_master b/test/tools/input_tests_master index 4050873b42..be6cf8f454 100644 --- a/test/tools/input_tests_master +++ b/test/tools/input_tests_master @@ -14,6 +14,9 @@ blg54 TBLtools.sh mksurfdata_map tools__s namelist smi24 TSMscript_tools.sh mksurfdata_map mksurfdata.pl mksrfdt_T31_crpglc_2000^tools__ds bli24 TBLscript_tools.sh mksurfdata_map mksurfdata.pl mksrfdt_T31_crpglc_2000^tools__ds +smi04 TSMscript_tools.sh mksurfdata_map mksurfdata.pl mksrfdt_f09_PtVg^tools__ds +bli04 TBLscript_tools.sh mksurfdata_map mksurfdata.pl mksrfdt_f09_PtVg^tools__ds + smi53 TSMscript_tools.sh mksurfdata_map mksurfdata.pl mksrfdt_10x15_1850^tools__o bli53 TBLscript_tools.sh mksurfdata_map mksurfdata.pl mksrfdt_10x15_1850^tools__o smi54 TSMscript_tools.sh mksurfdata_map mksurfdata.pl mksrfdt_10x15_1850^tools__ds diff --git a/test/tools/nl_files/mksrfdt_f09_PtVg b/test/tools/nl_files/mksrfdt_f09_PtVg new file mode 100644 index 0000000000..61c2d8325e --- /dev/null +++ b/test/tools/nl_files/mksrfdt_f09_PtVg @@ -0,0 +1 @@ +-l CSMDATA -r 0.9x1.25 -no-crop -y PtVg -exedir EXEDIR diff --git a/test/tools/tests_pretag_cheyenne_nompi b/test/tools/tests_pretag_cheyenne_nompi index 1f35731f8d..b80d9a78c1 100644 --- a/test/tools/tests_pretag_cheyenne_nompi +++ b/test/tools/tests_pretag_cheyenne_nompi @@ -2,6 +2,7 @@ smc#4 blc#4 sme14 ble14 sme@4 ble@4 smg54 blg54 +smi04 bli04 smi24 bli24 smi53 bli53 smi64 bli64 From 0e2490bf2cbbbeab4453e81f7b64afa0f89b2203 Mon Sep 17 00:00:00 2001 From: Erik Kluzek Date: Mon, 20 Apr 2020 13:15:08 -0600 Subject: [PATCH 6/7] Move section until when sim_yr0 is determined and use it rather than sim_year as sime_year can be a range. Also correct comment about loop over future scenarios --- tools/mksurfdata_map/mksurfdata.pl | 38 +++++++++++++++--------------- 1 file changed, 19 insertions(+), 19 deletions(-) diff --git a/tools/mksurfdata_map/mksurfdata.pl b/tools/mksurfdata_map/mksurfdata.pl index 457cc3146d..74b90963e1 100755 --- a/tools/mksurfdata_map/mksurfdata.pl +++ b/tools/mksurfdata_map/mksurfdata.pl @@ -704,7 +704,7 @@ sub write_namelist_file { # my $double = ".true."; # - # Loop over each sim_year + # Loop over each SSP-RCP scenario # RCP: foreach my $ssp_rcp ( @rcpaths ) { # @@ -719,24 +719,6 @@ sub write_namelist_file { next SIM_YEAR; } # - # Find the file for each of the types - # - foreach my $typ ( @typlist ) { - my $hgrid = $hgrd{$typ}; - my $lmask = $lmsk{$typ}; - my $filnm = $filnm{$typ}; - my $typ_cmd = "$scrdir/../../bld/queryDefaultNamelist.pl $mkopts -options " . - "hgrid=$hgrid,lmask=$lmask,mergeGIS=$merge_gis$mkcrop,sim_year=$sim_year -var $filnm"; - $datfil{$typ} = `$typ_cmd`; - $datfil{$typ} = trim($datfil{$typ}); - if ( $datfil{$typ} !~ /[^ ]+/ ) { - die "ERROR: could NOT find a $filnm data file for this resolution: $hgrid and type: $typ and $lmask.\n$typ_cmd\n\n"; - } - if ( ! defined($opts{'allownofile'}) && ! -f $datfil{$typ} ) { - die "ERROR: data file for this resolution does NOT exist ($datfil{$typ}).\n"; - } - } - # # If year is 1850-2000 actually run 1850-2015 # if ( $sim_year eq "1850-2000" ) { @@ -755,6 +737,24 @@ sub write_namelist_file { $sim_yrn = $2; $transient = 1; } + # + # Find the file for each of the types + # + foreach my $typ ( @typlist ) { + my $hgrid = $hgrd{$typ}; + my $lmask = $lmsk{$typ}; + my $filnm = $filnm{$typ}; + my $typ_cmd = "$scrdir/../../bld/queryDefaultNamelist.pl $mkopts -options " . + "hgrid=$hgrid,lmask=$lmask,mergeGIS=$merge_gis$mkcrop,sim_year=$sim_yr0 -var $filnm"; + $datfil{$typ} = `$typ_cmd`; + $datfil{$typ} = trim($datfil{$typ}); + if ( $datfil{$typ} !~ /[^ ]+/ ) { + die "ERROR: could NOT find a $filnm data file for this resolution: $hgrid and type: $typ and $lmask.\n$typ_cmd\n\n"; + } + if ( ! defined($opts{'allownofile'}) && ! -f $datfil{$typ} ) { + die "ERROR: data file for this resolution does NOT exist ($datfil{$typ}).\n"; + } + } # determine simulation year to use for the surface dataset: my $sim_yr_surfdat = "$sim_yr0"; From 27ed276e93ef634cc2a5e80319daf64cf0e1ee4a Mon Sep 17 00:00:00 2001 From: Erik Kluzek Date: Mon, 20 Apr 2020 22:09:32 -0600 Subject: [PATCH 7/7] Update date --- doc/release-clm5.0.ChangeLog | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/release-clm5.0.ChangeLog b/doc/release-clm5.0.ChangeLog index a1b23f3162..ac35550b72 100644 --- a/doc/release-clm5.0.ChangeLog +++ b/doc/release-clm5.0.ChangeLog @@ -1,7 +1,7 @@ =============================================================== Tag name: release-clm5.0.34 Originator(s): erik (Erik Kluzek,UCAR/TSS,303-497-1326) -Date: Mon Apr 20 11:27:34 MDT 2020 +Date: Mon Apr 20 22:08:42 MDT 2020 One-line Summary: Update documentation for release-clm5.0 branch, and fix issues with no-anthro surface dataset creation Purpose of this version: