CiteSource 0.2.1 — CRAN resubmission + incremental/deferred dedup#260
Merged
Conversation
Address remaining reviewer comment: Description no longer starts with "Tools for" (reworded to lead with an active verb). Bump DESCRIPTION date. Rewrite cran-comments.md as a new-package resubmission that documents how each reviewer point was addressed. Regenerate plot_source_overlap_upset.Rd.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Brings
enhanced-dedupintodevfor the CRAN 0.2.1 resubmission. This bundles the 0.2.1 feature work and the fixes for all CRAN reviewer comments on 0.2.0.CRAN reviewer comments (0.2.0 was rejected/held — never published) — all addressed
'shiny','RIS','CSV') single-quoted.\valuetags: added to all 5 flagged.Rdfiles (and every new 0.2.1 export).filenameremoved fromexport_*(); internalwrite_refs()fallback writes totempdir().New in 0.2.1
dedup_citations_add_sources().export_dedup_candidates()/reimport_dedup_candidates()+manual_dedup_completeflag inexport_csv().dedup_log().reimport_csv()reads all columns as character (re-dedup-safe).networkD3from Suggests.Checks
R CMD check --as-cran(local, Windows, R 4.5.0): 0 errors | 0 warnings | 0 notes. Submitted to win-builder R-devel.After merge, CRAN submission will be run from
dev.