Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added fix for AIRS v2.1 (obs4mips) #1472

Merged
merged 7 commits into from
Feb 8, 2022
Merged

Added fix for AIRS v2.1 (obs4mips) #1472

merged 7 commits into from
Feb 8, 2022

Conversation

axel-lauer
Copy link
Contributor

@axel-lauer axel-lauer commented Feb 4, 2022

Description

Adding

  1. Fix for the obs4mips dataset AIRS-2-1
  2. Custom variable clisccp

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 馃洜 Technical or 馃И Scientific review.


To help with the number pull requests:

Copy link
Contributor

@schlunma schlunma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!

I just have a very small comment. Apart from that a small test of this would be nice.

esmvalcore/cmor/_fixes/obs4mips/airs_2_1.py Outdated Show resolved Hide resolved
esmvalcore/cmor/_fixes/obs4mips/airs_2_1.py Outdated Show resolved Hide resolved
@schlunma schlunma changed the title Fixes for AIRS (obs4mips) and custom variable clisccp Added fixes for AIRS (obs4mips) and custom variable clisccp Feb 7, 2022
@schlunma schlunma added the fix for dataset Related to dataset-specific fix files label Feb 7, 2022
@schlunma schlunma added this to the v2.5.0 milestone Feb 7, 2022
@codecov
Copy link

codecov bot commented Feb 7, 2022

Codecov Report

Merging #1472 (3ac4175) into main (7c33581) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1472      +/-   ##
==========================================
+ Coverage   89.84%   89.85%   +0.01%     
==========================================
  Files         196      197       +1     
  Lines       10477    10489      +12     
==========================================
+ Hits         9413     9425      +12     
  Misses       1064     1064              
Impacted Files Coverage 螖
esmvalcore/cmor/_fixes/obs4mips/airs_2_1.py 100.00% <100.00%> (酶)

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 7c33581...3ac4175. Read the comment docs.

Copy link
Contributor

@schlunma schlunma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

馃帀

(Failing tests are not related to this PR)

@schlunma schlunma mentioned this pull request Feb 7, 2022
9 tasks
@axel-lauer axel-lauer changed the title Added fixes for AIRS (obs4mips) and custom variable clisccp Added fix for AIRS v2.1 (obs4mips) Feb 8, 2022
@axel-lauer
Copy link
Contributor Author

axel-lauer commented Feb 8, 2022

Tested the fix for AIRS v2.1, works fine. Also tested the fix for clisccp. This did not work any more, so I reverted the changes related to clisccp. I think this it is better to address clisccp this in a seperate pull request.

@schlunma
Copy link
Contributor

schlunma commented Feb 8, 2022

Awesome, thanks Axel!

@schlunma schlunma merged commit 683c88c into main Feb 8, 2022
@schlunma schlunma deleted the fix_cloudvars branch February 8, 2022 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix for dataset Related to dataset-specific fix files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants