Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move nested-lookup dependency to environment.yml to be installed from conda-forge instead of PyPi #1481

Merged
merged 3 commits into from Feb 8, 2022

Conversation

valeriupredoi
Copy link
Contributor

@valeriupredoi valeriupredoi commented Feb 8, 2022

Description

Just addressing my own comment here #1476 (comment) and going by the gentleman's agreement that we should get as many dependencies off conda-forge as possible


Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 馃洜 Technical or 馃И Scientific review.


To help with the number pull requests:

@codecov
Copy link

codecov bot commented Feb 8, 2022

Codecov Report

Merging #1481 (4a97371) into main (6ae6020) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1481   +/-   ##
=======================================
  Coverage   89.85%   89.85%           
=======================================
  Files         197      197           
  Lines       10489    10489           
=======================================
  Hits         9425     9425           
  Misses       1064     1064           

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 6ae6020...4a97371. Read the comment docs.

@valeriupredoi
Copy link
Contributor Author

thanks Manu! I assume Klaus is not unhappy either so am merging 馃嵑

@valeriupredoi valeriupredoi merged commit 6e47586 into main Feb 8, 2022
@valeriupredoi valeriupredoi deleted the move_nested-lookup_to_environmentYML branch February 8, 2022 15:25
@schlunma schlunma added the installation Installation problem label Feb 8, 2022
@schlunma schlunma added this to the v2.5.0 milestone Feb 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
installation Installation problem
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants