Conversation
|
Pending to improve the code coverage. |
Codecov Report
@@ Coverage Diff @@
## main #1627 +/- ##
=======================================
Coverage 91.38% 91.38%
=======================================
Files 204 204
Lines 11172 11173 +1
=======================================
+ Hits 10210 10211 +1
Misses 962 962
Continue to review full report at Codecov.
|
schlunma
left a comment
There was a problem hiding this comment.
Thanks for these quick changes Saskia, everything works fine now!!
One question: While testing this I realized that our data finder struggles to find data when the number of digits for the start year is longer than the number of digits of the end year (e.g. timerange: 200001/2001). The reason for this is that the comparison used to check if a file lies within the given timerange (start <= time_in_file <= end) never returns anything since the integer 200001 is never smaller than the integer 2001.
I don't think we can easily fix this in a general way, as padding these numbers automatically is quite dangerous (e.g., we also have 3-digit years, and can probably also have 5-digit years, in which cases an automatic padding would be plainly wrong).
I would suggest that we add a note to the doc that users need to be carefulhere and specify the same number of digits for the start and end period. Can I simply push this to this branch here? Thanks!!
|
I am not sure how this is related to this pull request, but if clarifying this is useful to you, please add the comments as needed. |
|
The problem I encountered was that I got missing data errors when using |
|
amazing, please push whatever is needed to the branch and approve it so it can be merged! |
Description
This PR adds a check that does not allow to combine
force_derivation: falseand wildcards in thetimerangetag and should the previousforce_derivation: falsebehaviour.Closes #1626
Link to documentation:
Before you get started
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.
To help with the number pull requests: