Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing unit for derived variable rsnstcsnorm to prevent overcorrection2 #846

Merged
merged 2 commits into from
Oct 28, 2020

Conversation

katjaweigel
Copy link
Contributor

@katjaweigel katjaweigel commented Oct 23, 2020

Fixing unit for derived variable rsnstcsnorm to prevent over correction caused by changes of #754. This time based on master. Sorry, the other branch (fix_derived_var_rsnstcsnorm) should be deleted.

Before you start, please read our contribution guidelines.

Tasks

  • Create an issue to discuss what you are going to do, if you haven't done so already (and add the link at the bottom)
  • This pull request has a descriptive title that can be used in a changelog
  • Add unit tests
  • Public functions should have a numpy-style docstring so they appear properly in the API documentation. For all other functions a one line docstring is sufficient.
  • If writing a new/modified preprocessor function, please update the documentation
  • Circle/CI tests pass. Status can be seen below your pull request. If the tests are failing, click the link to find out why.
  • Codacy code quality checks pass. Status can be seen below your pull request. If there is an error, click the link to find out why. If you suspect Codacy may be wrong, please ask by commenting.
  • Please use yamllint to check that your YAML files do not contain mistakes
  • If you make backward incompatible changes to the recipe format, make a new pull request in the ESMValTool repository and add the link below

If you need help with any of the tasks above, please do not hesitate to ask by commenting in the issue or pull request.


Contributes to close ESMValTool issue ESMValGroup/ESMValTool#1875 for recipe recipe_deangelis15nat.yml

…n caused by changes of PR754, this time based on master, sorry
Copy link
Contributor

@valeriupredoi valeriupredoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cheers @katjaweigel ! I added a unit test for good measure, @schlunma is on holidays, so @axel-lauer you wanna have a look, mate? Cheers

@axel-lauer
Copy link
Contributor

Sure, I'll take a look.

@bouweandela
Copy link
Member

I added a unit test for good measure

Awesome! That way it won't get broken again in the future!

Copy link
Contributor

@axel-lauer axel-lauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested this and it works nicely. This is ready for merging.

@axel-lauer axel-lauer merged commit 02b8f66 into master Oct 28, 2020
@axel-lauer axel-lauer deleted the fix_derived_var_rsnstcsnorm_master branch October 28, 2020 10:29
@valeriupredoi
Copy link
Contributor

cheers for revieweing @axel-lauer and @bouweandela 👍 🍺

@bouweandela
Copy link
Member

bouweandela commented Oct 28, 2020

Is this something we would want to make a bugfix release for? i.e. a version 2.1.1 of ESMValCore? @ESMValGroup/esmvaltool-coreteam

@valeriupredoi
Copy link
Contributor

shall we wait until iris3 becomes mainstream?

@katjaweigel
Copy link
Contributor Author

Not sure if it is important enough, maybe if there are also other issues?

@zklaus
Copy link
Contributor

zklaus commented Nov 20, 2020

In principle, I think it is worth a bugfix release. Maybe collect the bugfix PRs somehow (milestone? project? in the bugfix release branch) and cut the release when one of three conditions is met: A serious bug is fixed, some time has passed (this PR has been in for almost a month now), or the next release has come around?

@valeriupredoi I would (almost) never update an important dependency like Iris in a bugfix release, so I don't think that is a factor here.

@jvegreg jvegreg added the fix for dataset Related to dataset-specific fix files label Feb 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix for dataset Related to dataset-specific fix files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants