Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PRIMAVERA Eady Growth Rate diagnostic #1285

Merged
merged 57 commits into from Feb 17, 2021
Merged

Conversation

sloosvel
Copy link
Contributor

@sloosvel sloosvel commented Sep 4, 2019

Description

Recipe and diagnostic script to compute the Eady Growth Rate (PRIMAVERA)


Before you get started

Checklist

It is the responsibility of the author to make sure the PR is ready to review. The icons indicate whether the item will be subject to the πŸ›  Technical or πŸ§ͺ Scientific review.

New or updated recipe/diagnostic:


To help with the number pull requests:


@sloosvel sloosvel added the PRIMAVERA Metric from the PRIMAVERA project label Sep 4, 2019
@sloosvel sloosvel added this to To Do in PRIMAVERA via automation Sep 4, 2019
@sloosvel sloosvel moved this from To Do to In progress in PRIMAVERA Sep 5, 2019
@sloosvel sloosvel marked this pull request as ready for review October 16, 2019 10:48
@sloosvel sloosvel requested a review from jvegreg October 16, 2019 10:56
Co-Authored-By: Bouwe Andela <bouweandela@users.noreply.github.com>
@sloosvel sloosvel mentioned this pull request Oct 18, 2019
1 task
@sloosvel
Copy link
Contributor Author

Some of the models in the recipe require fixes, do I need to open an issue in the core? Or can I directly open a pull request? I already had them collected in a branch.

@nielsdrost nielsdrost added this to In Review in November 2020 Nov 26, 2020
Co-authored-by: Stef Smeets <stefsmeets@users.noreply.github.com>
@bouweandela
Copy link
Member

Scientific review-wise, I had people in our department making sure that the results make sense and are actually using them for their own work. Is that enough or would it be better to ask them to comment here?

Once you're done with all the technical work, I think it might be nice ask them to comment (and approve) here, to make it a bit more visible. It would be great if they could try out the new scientific review checklist.

@emchamarro
Copy link

emchamarro commented Feb 15, 2021

Hello,

The description looks fine. I think we could complete it with a reference:

documentation:
  description: |
    Recipe to compute the annual mean or the seasonal mean of the maximum Eady Growth Rate (EGR;
Brian J Hoskins and Paul J Valdes. On the existence of storm-tracks. Journal of the atmospheric sciences, 47(15):1854–1864, 1990.)
   The output produces netcdf files for each model. In the seasonal means, a plot is
    produced for each specified level showing the EGR values over the North-Atlantic region.

The plots look fine, but we could adapt the color scale for values between 0 and 1.1 or so, to see better the signal over the Atlantic. But this is just a suggestion.

I would approve the merge of this recipe.

@sloosvel
Copy link
Contributor Author

Thank you for the comments @emchamarro! Added the suggestions.

@sloosvel
Copy link
Contributor Author

@jvegasbsc can you take a look at this, I am not sure why some tests suddenly do not pass. Other than that I would say that everything is ready now?

@jvegreg
Copy link
Contributor

jvegreg commented Feb 15, 2021

Merge master, I think you need #2022

@sloosvel
Copy link
Contributor Author

It's already up do date. Do I need to do anything else to get this approved?

@jvegreg
Copy link
Contributor

jvegreg commented Feb 15, 2021

I got the same issues in other branches, so don't care

@sloosvel sloosvel changed the title PRIMAVERA Eady Growth Rate Add PRIMAVERA Eady Growth Rate diagnostic Feb 16, 2021
@jvegreg jvegreg merged commit b08fe2f into master Feb 17, 2021
PRIMAVERA automation moved this from In progress to Done Feb 17, 2021
@jvegreg jvegreg deleted the PRIMAVERA_eady_growth branch February 17, 2021 15:41
November 2020 automation moved this from In Review to Merged Feb 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
PRIMAVERA
  
Done
Development

Successfully merging this pull request may close these issues.

PRIMAVERA Eddy Growth Rate
6 participants