Applicate sea ice negative feedback #1299
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
October 9, 2017 16:12
…file metadata if not possible from filename
…ibutes to remove before concatenation
… config_developer file. It also allows now to be specified as a dict or as a single value
…o APPLICATE_sea_ice_negative_feedback Conflicts: esmvaltool/main.py
…o APPLICATE_sea_ice_negative_feedback
…edback # Conflicts: # esmvaltool/config-developer.yml # esmvaltool/diag_scripts/lib/python/esmval_lib.py # esmvaltool/interface_data/r_interface_templates/r.tmpl # esmvaltool/interface_scripts/cmor_check.py # esmvaltool/interface_scripts/data_finder.py # esmvaltool/interface_scripts/data_interface.py # esmvaltool/interface_scripts/launchers.py # esmvaltool/interface_scripts/preprocess.py # esmvaltool/interface_scripts/preprocessing_tools.py # esmvaltool/main.py
…PLICATE_sea_ice_negative_feedback
…coords can be aux coords)
added 2 commits
February 7, 2020 11:16
|
Ready to test after the two fixes PR are merged |
added 4 commits
February 21, 2020 15:30
|
Just updated and tested again with ESMValCore current master branch. Ready to test |
schlunma
requested changes
Mar 10, 2020
There was a problem hiding this comment.
On DKRZ we don't have the years 2000-2004 for CMCC-CESM, but I don't think this is a problem. Once I include those, the preprocessing runs fine, but the diagnostic fails with the following issue:
2020-03-10 12:55:14,007 [7516] INFO negative_seaice_feedback.py,319 [-5.45242937e-01 3.44169138e-16]
2020-03-10 12:55:14,153 [7516] INFO negative_seaice_feedback.py,97 Negative feedback: -0.5452
2020-03-10 12:55:14,153 [7516] INFO negative_seaice_feedback.py,98 P-Value: 0.0024
Traceback (most recent call last):
File "//ESMValTool/esmvaltool/diag_scripts/seaice_feedback/negative_seaice_feedback.py", line 450, in <module>
main()
File "/ESMValTool/esmvaltool/diag_scripts/seaice_feedback/negative_seaice_feedback.py", line 446, in main
NegativeSeaIceFeedback(config).compute()
File "/ESMValTool/esmvaltool/diag_scripts/seaice_feedback/negative_seaice_feedback.py", line 66, in compute
self._plot_comparison(negative_feedback, datasets)
File "/ESMValTool/esmvaltool/diag_scripts/seaice_feedback/negative_seaice_feedback.py", line 430, in _plot_comparison
group_metadata(self.cfg['input_data'].values(), )
TypeError: group_metadata() missing 1 required positional argument: 'attribute'
There are also lots of RuntimeWarning: overflow encountered in multiply warnings.
Here is the log.txt.
|
My last commit on Jasmin was not pushed ! 🤦♂ |
…com/ESMValGroup/ESMValTool into APPLICATE_sea_ice_negative_feedback
|
Done! |
Co-Authored-By: Manuel Schlund <32543114+schlunma@users.noreply.github.com>
schlunma
approved these changes
Mar 10, 2020
|
Recipe runs fine now, but I still get lots of |
mattiarighi
reviewed
Mar 10, 2020
Co-Authored-By: Mattia Righi <mattia.righi@dlr.de>
mattiarighi
reviewed
Mar 10, 2020
Co-Authored-By: Mattia Righi <mattia.righi@dlr.de>
mattiarighi
approved these changes
Mar 10, 2020
|
Please fix the failing test. |
|
I forgot to update the reference in the recipe with the new name |
|
Can we merge this, then? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.