New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Applicate sea ice negative feedback #1299
Conversation
…file metadata if not possible from filename
…ibutes to remove before concatenation
… config_developer file. It also allows now to be specified as a dict or as a single value
…o APPLICATE_sea_ice_negative_feedback Conflicts: esmvaltool/main.py
…o APPLICATE_sea_ice_negative_feedback
…edback # Conflicts: # esmvaltool/config-developer.yml # esmvaltool/diag_scripts/lib/python/esmval_lib.py # esmvaltool/interface_data/r_interface_templates/r.tmpl # esmvaltool/interface_scripts/cmor_check.py # esmvaltool/interface_scripts/data_finder.py # esmvaltool/interface_scripts/data_interface.py # esmvaltool/interface_scripts/launchers.py # esmvaltool/interface_scripts/preprocess.py # esmvaltool/interface_scripts/preprocessing_tools.py # esmvaltool/main.py
…PLICATE_sea_ice_negative_feedback
…coords can be aux coords)
Ready to test after the two fixes PR are merged |
Just updated and tested again with ESMValCore current master branch. Ready to test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On DKRZ we don't have the years 2000-2004 for CMCC-CESM, but I don't think this is a problem. Once I include those, the preprocessing runs fine, but the diagnostic fails with the following issue:
2020-03-10 12:55:14,007 [7516] INFO negative_seaice_feedback.py,319 [-5.45242937e-01 3.44169138e-16]
2020-03-10 12:55:14,153 [7516] INFO negative_seaice_feedback.py,97 Negative feedback: -0.5452
2020-03-10 12:55:14,153 [7516] INFO negative_seaice_feedback.py,98 P-Value: 0.0024
Traceback (most recent call last):
File "//ESMValTool/esmvaltool/diag_scripts/seaice_feedback/negative_seaice_feedback.py", line 450, in <module>
main()
File "/ESMValTool/esmvaltool/diag_scripts/seaice_feedback/negative_seaice_feedback.py", line 446, in main
NegativeSeaIceFeedback(config).compute()
File "/ESMValTool/esmvaltool/diag_scripts/seaice_feedback/negative_seaice_feedback.py", line 66, in compute
self._plot_comparison(negative_feedback, datasets)
File "/ESMValTool/esmvaltool/diag_scripts/seaice_feedback/negative_seaice_feedback.py", line 430, in _plot_comparison
group_metadata(self.cfg['input_data'].values(), )
TypeError: group_metadata() missing 1 required positional argument: 'attribute'
There are also lots of RuntimeWarning: overflow encountered in multiply
warnings.
Here is the log.txt.
My last commit on Jasmin was not pushed ! |
…com/ESMValGroup/ESMValTool into APPLICATE_sea_ice_negative_feedback
Done! |
Co-Authored-By: Manuel Schlund <32543114+schlunma@users.noreply.github.com>
Recipe runs fine now, but I still get lots of |
Co-Authored-By: Mattia Righi <mattia.righi@dlr.de>
Co-Authored-By: Mattia Righi <mattia.righi@dlr.de>
Please fix the failing test. |
I forgot to update the reference in the recipe with the new name |
Can we merge this, then? |
No description provided.