Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support extra installation methods in R #1360

Merged
merged 12 commits into from May 22, 2020
Merged

Conversation

jvegreg
Copy link
Contributor

@jvegreg jvegreg commented Oct 8, 2019

Added support for installing older versions of packages from CRAN

Also added support to direct install from GitHub or Git but with a note that this is only mean to be used during development, to speed up testing if the CRAN package is not yet available

First step towards solving #1350

@jvegreg jvegreg requested review from bouweandela and mattiarighi Oct 8, 2019
@mattiarighi
Copy link
Contributor

mattiarighi commented Oct 8, 2019

Isn't #1350 already solved by #1355?

@jvegreg
Copy link
Contributor Author

jvegreg commented Oct 8, 2019

Yes, @bouweandela was faster than I. This was to be the short term solution

Anyway, it is useful on its own, as will allow us to avoid issues with buggy releases or breaking changes in packages

@jvegreg
Copy link
Contributor Author

jvegreg commented Oct 8, 2019

Tests are failing because a timeout. Are any of you experiencing this in other branches?

@mattiarighi
Copy link
Contributor

mattiarighi commented Oct 8, 2019

Yes, it happened several times.

@valeriupredoi
Copy link
Contributor

valeriupredoi commented Oct 10, 2019

I likes, but I am not comfortable faffing around with older versions - I mean this could be needed as per the lintr issue, but I would not feel comfortable for users to do that at their leisure and then starting to report issues with unreproducible environments. I also found a way to install straight from the tarball in Archive #1350 (comment)

@jvegreg
Copy link
Contributor Author

jvegreg commented Oct 10, 2019

I likes, but I am not comfortable faffing around with older versions - I mean this could be needed as per the lintr issue, but I would not feel comfortable for users to do that at their leisure and then starting to report issues with unreproducible environments. I also found a way to install straight from the tarball in Archive #1350 (comment)

I agree, but we need something that allow us to pin versions of R packages if needed, as we do with conda and PyPI when needed. We just need to state clearly that we only pin a version if there is some issue with the newest one on CRAN

@valeriupredoi
Copy link
Contributor

valeriupredoi commented Oct 10, 2019

bjoernbroetz and others added 6 commits Nov 28, 2019
In a new R-installation there is no `yaml`-package installed. To make
use of the new format for r dependencies as a .yml-file we need to install
it first here.

Also package `ncdf.helpers` removed due to its removal from CRAN. See
PR #1454 and references therein.
@bouweandela
Copy link
Member

bouweandela commented Jan 3, 2020

@jvegasbsc This pull request seems to contain a new CMORizer as well now. Could you please clean up and let me know when it's ready for review?

@mattiarighi mattiarighi changed the base branch from version2_development to master Jan 3, 2020
@bouweandela
Copy link
Member

bouweandela commented Apr 28, 2020

@jvegasbsc Any news on this?

@jvegreg
Copy link
Contributor Author

jvegreg commented Apr 28, 2020

Yes, ready to test

@bouweandela
Copy link
Member

bouweandela commented May 12, 2020

Thanks, looks good! @mattiarighi Would you be able to test this?

@mattiarighi mattiarighi merged commit 4b13358 into master May 22, 2020
6 checks passed
@mattiarighi mattiarighi deleted the r_install_from_github branch May 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants