-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support extra installation methods in R #1360
Conversation
Yes, @bouweandela was faster than I. This was to be the short term solution Anyway, it is useful on its own, as will allow us to avoid issues with buggy releases or breaking changes in packages |
Tests are failing because a timeout. Are any of you experiencing this in other branches? |
Yes, it happened several times. |
I likes, but I am not comfortable faffing around with older versions - I mean this could be needed as per the lintr issue, but I would not feel comfortable for users to do that at their leisure and then starting to report issues with unreproducible environments. I also found a way to install straight from the tarball in Archive #1350 (comment) |
I agree, but we need something that allow us to pin versions of R packages if needed, as we do with conda and PyPI when needed. We just need to state clearly that we only pin a version if there is some issue with the newest one on CRAN |
Okeydokey, in that case it should be fine. Cheers for implementing this,
man!
Dr Valeriu Predoi.
Computational scientist
NCAS-CMS
University of Reading
Department of Meteorology
Reading RG6 6BB
United Kingdom
…On Thu, 10 Oct 2019, 15:05 Javier Vegas-Regidor, ***@***.***> wrote:
I likes, but I am not comfortable faffing around with older versions - I
mean this could be needed as per the lintr issue, but I would not feel
comfortable for users to do that at their leisure and then starting to
report issues with unreproducible environments. I also found a way to
install straight from the tarball in Archive #1350
<#1350> (comment)
I agree, but we need something that allow us to pin versions of R packages
if needed, as we do with conda and PyPI when needed. We just need to state
clearly that we only pin a version if there is some issue with the newest
one on CRAN
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#1360?email_source=notifications&email_token=AG5EFIZKJYUPSM7SPI4EAE3QN4ZDXA5CNFSM4I6OLNSKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEA4PD3Q#issuecomment-540602862>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AG5EFIZTJQ4CEFHJ4JI3SL3QN4ZDXANCNFSM4I6OLNSA>
.
|
…/ESMValTool into r_install_from_github
In a new R-installation there is no `yaml`-package installed. To make use of the new format for r dependencies as a .yml-file we need to install it first here. Also package `ncdf.helpers` removed due to its removal from CRAN. See PR #1454 and references therein.
…/ESMValTool into r_install_from_github
…p/ESMValTool into r_install_from_github
…/ESMValTool into r_install_from_github
@jvegasbsc This pull request seems to contain a new CMORizer as well now. Could you please clean up and let me know when it's ready for review? |
@jvegasbsc Any news on this? |
…to r_install_from_github
Yes, ready to test |
Thanks, looks good! @mattiarighi Would you be able to test this? |
Added support for installing older versions of packages from CRAN
Also added support to direct install from GitHub or Git but with a note that this is only mean to be used during development, to speed up testing if the CRAN package is not yet available
First step towards solving #1350