Remove reference section in config-references.yml

[SarahAlidoost]

Before you start, read CONTRIBUTING.md and the guide for diagnostic developers.

Please discuss your idea with the development team before getting started, to avoid disappointment later. The way to do this is to open a new issue on GitHub. If you are planning to modify an existing functionality, please discuss it with the original author(s) by tagging them in the issue.

---

Tasks

• Create an issue to discuss what you are going to do, if you haven't done so already (and add the link at the bottom)
• Give this pull request a descriptive title that can be used as a one line summary in a changelog
• Make sure your code is composed of functions of no more than 50 lines and uses meaningful names for variables
• Circle/CI tests pass. Status can be seen below your pull request. If the tests are failing, click the link to find out why.
• Preferably Codacy code quality checks pass, however a few remaining hard to solve Codacy issues are still acceptable. Status can be seen below your pull request. If there is an error, click the link to find out why. If you suspect Codacy may be wrong, please ask by commenting.
• Please use yamllint to check that your YAML files do not contain mistakes
  If you need help with any of the tasks above, please do not hesitate to ask by commenting in the issue or pull request.

---

Closes #1513
It is related to ESMValGroup/ESMValCore#402

[bouweandela]

As discussed offline, the cmorizers also need to be updated so the tags from their configuration files are replaced with a nice string generated from the bibtex.

[SarahAlidoost]

As discussed offline, the cmorizers also need to be updated so the tags from their configuration files are replaced with a nice string generated from the bibtex.

thanks. This option will be added to this PR ESMValGroup/ESMValCore#402

[bouweandela]

Thanks for the improvements! Here are a few more comments

[bouweandela]

Suggested change

	def _test_reference_tags(recipe_file):
	recipe = yaml.safe_load(recipe_file.read_text())
	value = recipe['documentation']['references']
	_check_bibtex_exist(value)
	def _check_bibtex_exist(tag):
	"""Check bibtex file is added to REFERENCES_PATH."""
	bibtex_file = REFERENCES_PATH / f'{tag}.bibtex'
	assert not bibtex_file.is_file()
	def test_reference_tags(recipe_file):
	recipe = yaml.safe_load(recipe_file.read_text())
	tags = recipe.get('documentation', {}).get('references', [])
	for tag in tags:
	bibtex_file = REFERENCES_PATH / f'{tag}.bibtex'
	assert not bibtex_file.is_file()

• The name of the function has to start with test_ so pytest knows it is a test.
• It would be good to write the test in such a way that recipes without a documentation/references list do not cause the test to fail, because that is not what we are checking here
• Note that the content of references in the recipe is a list of strings, not a single string
• It would be great if you could make a nice error message with a link to the documentation on adding a bibtex file to esmvaltool/references

[SarahAlidoost]

@bouweandela Thanks a lot. the error message is added. Also, running this test shows that some bibtex files are missing in the references folder. I added those.

@mattiarighi there are two tags in the current config-references.yml: cds-satellite-albedo, and mls-aura. I couldn't find any citation information about the first tag. It seems that the provided link is for data in zip format rather than a reference entry. For the second one, I made its bibtex file. Could you please check these two tags? Thanks.

[bouweandela]

A new release of ESMValCore including ESMValGroup/ESMValCore#402 is needed before this can be merged, also for making the tests pass. Ready for testing though, @mattiarighi.