-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New recipe/diagnostic: recipe_li17natcc.yml for Axels GMD Paper #1567
Conversation
…yml, and documentation: recipe_li17natcc.rst, index.rst for linatcc
ci/circleci: test_installation — Your tests failed on CircleCI |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Output looks good, documentation looks good 👍
(Tested on DKRZ)
The recipe also finishes fine on Jasmin. the MRI-CGCM3 dataset is not accessible, but other than that everything else is fine. |
…ow missing on Mistral (MRI-ESM2-0)
Co-Authored-By: Manuel Schlund <32543114+schlunma@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great @katjaweigel! @mattiarighi Could you please do a final test and merge?
@axel-lauer can you have a go at this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Testing of the diagnostic was successful, looks all good!
Before you start, read CONTRIBUTING.md and the guide for diagnostic developers.
Please discuss your idea with the development team before getting started, to avoid disappointment later. The way to do this is to open a new issue on GitHub. If you are planning to modify an existing functionality, please discuss it with the original author(s) by tagging them in the issue.
Tasks
yamllint
to check that your YAML files do not contain mistakesdoc/sphinx/source/recipes
folder and add a new entry to index.rstIf you need help with any of the tasks above, please do not hesitate to ask by commenting in the issue or pull request.
Closes #1566