Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New recipe/diagnostic: recipe_li17natcc.yml for Axels GMD Paper #1567

Merged
merged 15 commits into from Apr 29, 2020

Conversation

katjaweigel
Copy link
Contributor

@katjaweigel katjaweigel commented Mar 4, 2020

Before you start, read CONTRIBUTING.md and the guide for diagnostic developers.

Please discuss your idea with the development team before getting started, to avoid disappointment later. The way to do this is to open a new issue on GitHub. If you are planning to modify an existing functionality, please discuss it with the original author(s) by tagging them in the issue.


Tasks

  • Create an issue to discuss what you are going to do, if you haven't done so already (and add the link at the bottom)
  • Give this pull request a descriptive title that can be used as a one line summary in a changelog
  • Make sure your code is composed of functions of no more than 50 lines and uses meaningful names for variables
  • Circle/CI tests pass. Status can be seen below your pull request. If the tests are failing, click the link to find out why.
  • Preferably Codacy code quality checks pass, however a few remaining hard to solve Codacy issues are still acceptable. Status can be seen below your pull request. If there is an error, click the link to find out why. If you suspect Codacy may be wrong, please ask by commenting.
  • Please use yamllint to check that your YAML files do not contain mistakes
  • Add documentation for the recipe to the doc/sphinx/source/recipes folder and add a new entry to index.rst
  • Add provenance information

If you need help with any of the tasks above, please do not hesitate to ask by commenting in the issue or pull request.


Closes #1566

“katjaweigel” added 3 commits Mar 3, 2020
@katjaweigel katjaweigel requested a review from axel-lauer Mar 4, 2020
@katjaweigel
Copy link
Contributor Author

katjaweigel commented Mar 4, 2020

ci/circleci: test_installation — Your tests failed on CircleCI
Could that be related to issue #1565?

@katjaweigel katjaweigel self-assigned this Mar 6, 2020
@jvegreg jvegreg added this to the PRIMAVERA MS3 milestone Mar 10, 2020
@schlunma schlunma requested review from schlunma and jvegreg Mar 10, 2020
Copy link
Contributor

@schlunma schlunma left a comment

Output looks good, documentation looks good 👍

(Tested on DKRZ)

doc/sphinx/source/recipes/recipe_li17natcc.rst Outdated Show resolved Hide resolved
doc/sphinx/source/recipes/recipe_li17natcc.rst Outdated Show resolved Hide resolved
@jvegreg jvegreg removed this from the PRIMAVERA MS3 milestone Mar 10, 2020
@jvegreg jvegreg requested a review from sloosvel Mar 10, 2020
@sloosvel
Copy link
Contributor

sloosvel commented Mar 10, 2020

The recipe also finishes fine on Jasmin. the MRI-CGCM3 dataset is not accessible, but other than that everything else is fine.

@sloosvel sloosvel self-requested a review Mar 19, 2020
bouweandela and others added 3 commits Apr 28, 2020
Co-Authored-By: Manuel Schlund <32543114+schlunma@users.noreply.github.com>
Copy link
Member

@bouweandela bouweandela left a comment

Looks great @katjaweigel! @mattiarighi Could you please do a final test and merge?

@mattiarighi
Copy link
Contributor

mattiarighi commented Apr 28, 2020

@axel-lauer can you have a go at this?
I have several other PRs to test at the moment.
Thank you!

Copy link
Contributor

@axel-lauer axel-lauer left a comment

Testing of the diagnostic was successful, looks all good!

@axel-lauer axel-lauer merged commit 14c7dff into master Apr 29, 2020
5 of 6 checks passed
@axel-lauer axel-lauer deleted the linatcc_for_gmdpart4 branch Apr 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New recipe/diagnostic: recipe_li17natcc.yml for Axels GMD Paper
7 participants