Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various improvements to development infrastructure #1570

Merged
merged 16 commits into from Apr 8, 2020
Merged

Conversation

bouweandela
Copy link
Member

@bouweandela bouweandela commented Mar 5, 2020

Various improvements to development infrastructure

  • Simplified setup.py/setup.cfg
  • Mention nclcodestyle in CONTRIBUTING.md
  • Mention codespell in CONTRIBUTING.md
  • Enable more lintr linters
  • Documentation on how to make a release
  • Conda package files now located in the conda package directory
  • Run more relevant tests on CircleCI
  • Unpin matplotlib, tiledb, libblas
  • Remove the dependency on mock by using unittest.mock from the standard library instead

Tasks

  • Create an issue to discuss what you are going to do, if you haven't done so already (and add the link at the bottom)
  • Give this pull request a descriptive title that can be used as a one line summary in a changelog
  • Circle/CI tests pass. Status can be seen below your pull request. If the tests are failing, click the link to find out why.
  • Preferably Codacy code quality checks pass, however a few remaining hard to solve Codacy issues are still acceptable. Status can be seen below your pull request. If there is an error, click the link to find out why. If you suspect Codacy may be wrong, please ask by commenting.
  • Please use yamllint to check that your YAML files do not contain mistakes

bouweandela added 4 commits Mar 5, 2020
- Simplified setup.py/setup.cfg

- Mention nclcodestyle in CONTRIBUTING.md

- Mention codespell in CONTRIBUTING.md

- Enable more lintr linters
@bouweandela
Copy link
Member Author

bouweandela commented Apr 3, 2020

Note that the conda build is failing on CircleCI because it runs out of memory. When running it on a machine with more memory, it works just fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants