Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New recipe/diagnostics: recipe_deangelis_for_gmdpart4.yml for Axels GMD Paper #1576

Merged
merged 76 commits into from Apr 30, 2020

Conversation

katjaweigel
Copy link
Contributor

@katjaweigel katjaweigel commented Mar 9, 2020

Before you start, read CONTRIBUTING.md and the guide for diagnostic developers.

Please discuss your idea with the development team before getting started, to avoid disappointment later. The way to do this is to open a new issue on GitHub. If you are planning to modify an existing functionality, please discuss it with the original author(s) by tagging them in the issue.


Tasks

  • Create an issue to discuss what you are going to do, if you haven't done so already (and add the link at the bottom)
  • Give this pull request a descriptive title that can be used as a one line summary in a changelog
  • Make sure your code is composed of functions of no more than 50 lines and uses meaningful names for variables
  • Circle/CI tests pass. Status can be seen below your pull request. If the tests are failing, click the link to find out why.
  • Preferably Codacy code quality checks pass, however a few remaining hard to solve Codacy issues are still acceptable. Status can be seen below your pull request. If there is an error, click the link to find out why. If you suspect Codacy may be wrong, please ask by commenting.
  • Please use yamllint to check that your YAML files do not contain mistakes
  • Add documentation for the recipe to the doc/sphinx/source/recipes folder and add a new entry to index.rst
  • Add provenance information

If you need help with any of the tasks above, please do not hesitate to ask by commenting in the issue or pull request.


Closes #1575

“katjaweigel” and others added 30 commits Nov 8, 2019
Merge remote-tracking branch 'origin/master' into deangelis_for_gmdpart4
Merge remote-tracking branch 'origin/master' into deangelis_for_gmdpart4
@katjaweigel katjaweigel marked this pull request as ready for review Mar 20, 2020
Copy link
Member

@bouweandela bouweandela left a comment

Looks great @katjaweigel! @mattiarighi Could you please test and take care of scientific review?

@axel-lauer
Copy link
Contributor

axel-lauer commented Apr 29, 2020

Running some tests now...

@axel-lauer
Copy link
Contributor

axel-lauer commented Apr 30, 2020

When trying to run this recipe, I get the following error message:

2020-04-30 00:27:30,406 [34789] INFO deangelisf2ext.py,347 Saving analysis results to /mnt/lustre02/work/bd0854/b380103/esmvaltool_output/recipe_deangelis15nat_20200429_180349/work/deangelisf2ext/deangelisf2ext/fig2a.nc Traceback (most recent call last): File "/mnt/lustre02/work/bd0854/b380103/ESMValTool/esmvaltool/diag_scripts/deangelis15nat/deangelisf2ext.py", line 818, in <module> main(config) File "/mnt/lustre02/work/bd0854/b380103/ESMValTool/esmvaltool/diag_scripts/deangelis15nat/deangelisf2ext.py", line 812, in main plot_slope_regression(cfg, data_dict) File "/mnt/lustre02/work/bd0854/b380103/ESMValTool/esmvaltool/diag_scripts/deangelis15nat/deangelisf2ext.py", line 365, in plot_slope_regression iris.save(cube_to_save_vars(list_dict), target=diagnostic_file) File "/mnt/lustre02/work/bd0854/b380103/ESMValTool/esmvaltool/diag_scripts/deangelis15nat/deangelisf2ext.py", line 276, in cube_to_save_vars units=list_dict["name"][iii]['units'])]) File "/mnt/lustre02/work/bd0854/b380103/miniconda3/envs/esmvaltool/lib/python3.7/site-packages/iris/cube.py", line 774, in __init__ self.var_name = var_name File "/mnt/lustre02/work/bd0854/b380103/miniconda3/envs/esmvaltool/lib/python3.7/site-packages/iris/_cube_coord_common.py", line 270, in var_name raise ValueError(emsg.format(name)) ValueError: 'dlvp/dtas' is not a valid NetCDF variable name.

@katjaweigel Could you possibly take a look? I guess this might be relatively easy to fix?!

@katjaweigel
Copy link
Contributor Author

katjaweigel commented Apr 30, 2020

@axel-lauer Thanks for your test, message, I'll run a test now.

@katjaweigel
Copy link
Contributor Author

katjaweigel commented Apr 30, 2020

Unfortunately I need a new Core, that could slow it down since there is an recent issue on core installation ...

@mattiarighi
Copy link
Contributor

mattiarighi commented Apr 30, 2020

Are you referring to ESMValGroup/ESMValCore#624 ?
This is only when installing in development mode, if you install ESMValCore as a dependency in the standard way it should not be an issue.

@katjaweigel
Copy link
Contributor Author

katjaweigel commented Apr 30, 2020

@mattiarighi thanks, but I usually use development mode, but for me
pip install -e '.[develop]' worked, see other issue

@katjaweigel
Copy link
Contributor Author

katjaweigel commented Apr 30, 2020

@axel-lauer I changed the variable names for the netCDF files, can you check if theses work for you (here is runs with both versions)?

@axel-lauer
Copy link
Contributor

axel-lauer commented Apr 30, 2020

Rerunning the test of deangelisf2ext.py...

@axel-lauer
Copy link
Contributor

axel-lauer commented Apr 30, 2020

All tests have been successful now! The plots look good. Ready to be merged!

@axel-lauer axel-lauer merged commit 4b5c1f2 into master Apr 30, 2020
6 checks passed
@axel-lauer axel-lauer deleted the deangelis_for_gmdpart4 branch Apr 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New recipe/diagnostic: recipe_deangelis_for_gmdpart4.yml for Axels GMD Paper
5 participants