-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New recipe/diagnostics: recipe_deangelis_for_gmdpart4.yml for Axels GMD Paper #1576
Conversation
Merge remote-tracking branch 'origin/master' into deangelis_for_gmdpart4
…nd model experiment used.
Merge remote-tracking branch 'origin/master' into deangelis_for_gmdpart4
… start test if running)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great @katjaweigel! @mattiarighi Could you please test and take care of scientific review?
Running some tests now... |
When trying to run this recipe, I get the following error message:
@katjaweigel Could you possibly take a look? I guess this might be relatively easy to fix?! |
@axel-lauer Thanks for your test, message, I'll run a test now. |
Unfortunately I need a new Core, that could slow it down since there is an recent issue on core installation ... |
Are you referring to ESMValGroup/ESMValCore#624 ? |
@mattiarighi thanks, but I usually use development mode, but for me |
…lis15nat/deangelisf2ext.py
@axel-lauer I changed the variable names for the netCDF files, can you check if theses work for you (here is runs with both versions)? |
Rerunning the test of deangelisf2ext.py... |
All tests have been successful now! The plots look good. Ready to be merged! |
Before you start, read CONTRIBUTING.md and the guide for diagnostic developers.
Please discuss your idea with the development team before getting started, to avoid disappointment later. The way to do this is to open a new issue on GitHub. If you are planning to modify an existing functionality, please discuss it with the original author(s) by tagging them in the issue.
Tasks
yamllint
to check that your YAML files do not contain mistakesdoc/sphinx/source/recipes
folder and add a new entry to index.rstIf you need help with any of the tasks above, please do not hesitate to ask by commenting in the issue or pull request.
Closes #1575