Cmorizer for HALOE

[mattiarighi]

Before you start, read CONTRIBUTING.md and the guide for diagnostic developers.

Please discuss your idea with the development team before getting started, to avoid disappointment later. The way to do this is to open a new issue on GitHub. If you are planning to modify an existing functionality, please discuss it with the original author(s) by tagging them in the issue.

---

Tasks

• Create an issue to discuss what you are going to do, if you haven't done so already (and add the link at the bottom)
• Give this pull request a descriptive title that can be used as a one line summary in a changelog
• Make sure your code is composed of functions of no more than 50 lines and uses meaningful names for variables
• Circle/CI tests pass. Status can be seen below your pull request. If the tests are failing, click the link to find out why.
• Preferably Codacy code quality checks pass, however a few remaining hard to solve Codacy issues are still acceptable. Status can be seen below your pull request. If there is an error, click the link to find out why. If you suspect Codacy may be wrong, please ask by commenting.
• Please use yamllint to check that your YAML files do not contain mistakes
• (Only if really necessary) Add any additional dependencies needed for the diagnostic script to setup.py, esmvaltool/install/R/r_requirements.txt or esmvaltool/install/Julia/julia_requirements.txt (depending on the language of your script) and also to meta.yaml for conda dependencies (includes Python and others, but not R/Julia)
• If new dependencies are introduced, check that the license is compatible with Apache2.0

New recipe/diagnostic

• Add documentation for the recipe to the doc/sphinx/source/recipes folder and add a new entry to index.rst
• Add provenance information

Modified recipe/diagnostic

• Update documentation for the recipe to the doc/sphinx/source/recipes folder
• Update provenance information if needed
• Assign the author(s) of the affected recipe(s) as reviewer(s)

New data reformatting script

• Test the CMORized data using recipes/example/recipe_check_obs.yml, to make sure the CMOR checks pass without errors
• Add the new dataset to the table in the documentation
• Tag @mattiarighi in this pull request, so that the new dataset can be added to the OBS data pool at DKRZ and synchronized with CEDA-Jasmin

Modified data reformatting script

• Test the CMORized data using recipes/example/recipe_check_obs.yml, to make sure the CMOR checks pass without errors
• Tag @mattiarighi in this pull request, so that the updated dataset can be added to the OBS data pool at DKRZ and synchronized with CEDA-Jasmin

If you need help with any of the tasks above, please do not hesitate to ask by commenting in the issue or pull request.

---

Requires ESMValGroup/ESMValCore#567

[hb326]

Looks good to me. How difficult would it be to add the other variables? Would that just be an extension of the code?

[mattiarighi]

Just extend the arrays VAR and NAME accordingly.

[hb326]

Just extend the arrays VAR and NAME accordingly.

Thanks!! You are the best!

[mattiarighi]

I think a new release of ESMValCore is required for the tests to pass, due to the new custom table introduced in ESMValGroup/ESMValCore#567.

[mattiarighi]

@axel-lauer @hb326
Can you please cross-check the unit conversion?
See here for example.

[axel-lauer]

This looks correct. E.g. for CMIP6, it is explicitely in the CMOR tables that hus is given in kg (H2O) per kg (moist air):
"comment": "Specific humidity is the mass fraction of water vapor in (moist) air."
so the conversion of the HALOE data from m3/m3 to kg(H2O)/kg(moist air) as done here is correct.

[mattiarighi]

Thanks! Please approve so I can merge.

[axel-lauer]

Looks all fine. Double-checked conversion of variable ‚hus’, looks correct.