Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Install scikit-learn from conda, remove libunwind as a direct dependency #1611

Merged
merged 8 commits into from
Apr 16, 2020
Merged

Install scikit-learn from conda, remove libunwind as a direct dependency #1611

merged 8 commits into from
Apr 16, 2020

Conversation

valeriupredoi
Copy link
Contributor

@valeriupredoi valeriupredoi commented Apr 6, 2020 •
edited by bouweandela
Loading

Key Features

  • Moving installation of scikit-learn from conda-forge instead of pypi since I noticed build issues in Build of scikit-learn problematic if from pypi #1610
  • Relax requirements so that now netcdf4 installs the latest version with parallel write enabled via mpi_mpich
  • Changes:
    • removed libunwind

Tasks

  • Create an issue to discuss what you are going to do, if you haven't done so already (and add the link at the bottom)
  • Give this pull request a descriptive title that can be used as a one line summary in a changelog
  • Circle/CI tests pass. Status can be seen below your pull request. If the tests are failing, click the link to find out why.
  • Preferably Codacy code quality checks pass, however a few remaining hard to solve Codacy issues are still acceptable. Status can be seen below your pull request. If there is an error, click the link to find out why. If you suspect Codacy may be wrong, please ask by commenting.

Closes #1610 and #1612

@valeriupredoi
Copy link
Contributor Author

valeriupredoi commented Apr 7, 2020 •
edited
Loading

btw why are the doc tests failing? -> nevermind, they're passing now 🎉

@valeriupredoi valeriupredoi changed the title moved installation of scikit-learn to conda Clean up and optimize environment (with netcdf4 parallel write enabled) Apr 7, 2020
@bouweandela
Copy link
Member

There seems to be some overlap with #1570, could you address the merge conflicts and check what is still needed?

@valeriupredoi
Copy link
Contributor Author

done! 🍺

@valeriupredoi
Copy link
Contributor Author

...and passed testy-tests 😁

jvegreg
jvegreg reviewed Apr 9, 2020
View reviewed changes
setup.py Show resolved Hide resolved
bouweandela
bouweandela reviewed Apr 16, 2020
View reviewed changes
environment.yml Outdated Show resolved Hide resolved
@bouweandela bouweandela changed the title Clean up and optimize environment (with netcdf4 parallel write enabled) Install scikit-learn from conda, remove libunwind as a direct dependency Apr 16, 2020
@bouweandela bouweandela merged commit b4b138d into master Apr 16, 2020
@bouweandela bouweandela deleted the move_scikit-learn_to_conda branch April 16, 2020 12:31
@valeriupredoi
Copy link
Contributor Author

valeriupredoi commented Apr 16, 2020 •
edited
Loading

build was failing, was aboot to investigate that, was it just a hiccup on the CI machine and eventually had passed when you merged? @bouweandela

@bouweandela
Copy link
Member

Conda build probably ran out of memory, happens all the time

@valeriupredoi
Copy link
Contributor Author

we need to investigate that, man, that's pretty annoying, cheers for merging 🍺

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jvegreg jvegreg jvegreg left review comments

@bouweandela bouweandela bouweandela approved these changes

Assignees
No one assigned
Labels
installation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Build of scikit-learn problematic if from pypi
3 participants
@valeriupredoi @bouweandela @jvegreg