Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create conda subpackages and enable tests #1624

Merged
merged 3 commits into from
Apr 21, 2020
Merged

Create conda subpackages and enable tests #1624

merged 3 commits into from
Apr 21, 2020

Conversation

bouweandela
Copy link
Member

@bouweandela bouweandela commented Apr 20, 2020

Create conda subpackages and run tests after building

Closes #1615
Closes #448

Adds test for the problem reported in issue #1617


Tasks

  • Create an issue to discuss what you are going to do, if you haven't done so already (and add the link at the bottom)
  • Give this pull request a descriptive title that can be used as a one line summary in a changelog
  • Make sure your code is composed of functions of no more than 50 lines and uses meaningful names for variables
  • Circle/CI tests pass. Status can be seen below your pull request. If the tests are failing, click the link to find out why.
  • Preferably Codacy code quality checks pass, however a few remaining hard to solve Codacy issues are still acceptable. Status can be seen below your pull request. If there is an error, click the link to find out why. If you suspect Codacy may be wrong, please ask by commenting.
  • Please use yamllint to check that your YAML files do not contain mistakes
  • Update the installation documentation

@bouweandela bouweandela marked this pull request as ready for review April 20, 2020 12:48
@bouweandela
Copy link
Member Author

The conda build is failing the second time because it runs out of memory when testing if the R packages can be compiled, it works fine on a machine with more memory.

Co-Authored-By: Mattia Righi <mattia.righi@dlr.de>
@bouweandela bouweandela merged commit b577f18 into master Apr 21, 2020
@bouweandela bouweandela deleted the conda-package branch April 21, 2020 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make ESMValTool conda installation more flexible Run unit tests when creating conda package
2 participants