Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Miles default domains to include lat=0 #1626

Merged
merged 2 commits into from Apr 27, 2020
Merged

Miles default domains to include lat=0 #1626

merged 2 commits into from Apr 27, 2020

Conversation

jhardenberg
Copy link
Contributor

@jhardenberg jhardenberg commented Apr 21, 2020

This is a minor maintenance PR extending the default NH domain used by all miles recipes (blocking regimes and eofs) to include also lat=0 (before it started at 2.5N).
For blocking this is essential for the computation of the "ExtraBlock" indices (based on constraint (A4) in Davini et al. 2012). Without lat=0 the code currently accesses an array at position 0 (not valid in R) but keeps running. Actually this has no significant impact on the scientific results of the recipes.
While the user should not change the domain specified in the preprocessor part of the recipe, I still added a check in the blocking calculation to avoid this possibility.

Copy link
Member

@bouweandela bouweandela left a comment

Thanks, looks good to me! @mattiarighi Could you please test and do scientific review?

@mattiarighi mattiarighi merged commit 895bd77 into master Apr 27, 2020
6 checks passed
@mattiarighi mattiarighi deleted the miles_0lat branch Apr 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants