Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cmorizer for the PERSIANN-CDR precipitation data #1633

Merged
merged 5 commits into from Apr 29, 2020

Conversation

hb326
Copy link
Contributor

@hb326 hb326 commented Apr 27, 2020

Tasks

  • Create an issue to discuss what you are going to do, if you haven't done so already (and add the link at the bottom)
  • Give this pull request a descriptive title that can be used as a one line summary in a changelog
  • Make sure your code is composed of functions of no more than 50 lines and uses meaningful names for variables
  • Circle/CI tests pass. Status can be seen below your pull request. If the tests are failing, click the link to find out why.
  • Preferably Codacy code quality checks pass, however a few remaining hard to solve Codacy issues are still acceptable. Status can be seen below your pull request. If there is an error, click the link to find out why. If you suspect Codacy may be wrong, please ask by commenting.
  • Please use yamllint to check that your YAML files do not contain mistakes

New data reformatting script

  • Test the CMORized data using recipes/example/recipe_check_obs.yml, to make sure the CMOR checks pass without errors
  • Add the new dataset to the table in the documentation
  • Tag @mattiarighi in this pull request, so that the new dataset can be added to the OBS data pool at DKRZ and synchronized with CEDA-Jasmin

Closes {Link to corresponding issue}

Copy link
Member

@bouweandela bouweandela left a comment

Looks good to me! @mattiarighi Could you please test and do scientific review?

@axel-lauer
Copy link
Contributor

axel-lauer commented Apr 28, 2020

Testing this right now...

Copy link
Contributor

@axel-lauer axel-lauer left a comment

The test was successful, the cmorizer does what it is supposed to do. Thumbs up!

@axel-lauer axel-lauer merged commit 03b10d5 into master Apr 29, 2020
6 checks passed
@axel-lauer axel-lauer deleted the version2_cmorize_persiann-cdr_data branch Apr 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants