-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add colortables as esmvaltool subcommand #1666
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried this out and it seems to work nicely. Maybe it would be good to specify a directory in which to save the plots? Because now the command creates a lot of files in the current working directory.
@jvegasbsc Could you have a look at the merge conflict? |
…to new_cli_adaptation
@jvegasbsc there are some codacy issues, could you have a look? |
Most of those are related to the imports not being in the top but in the functions. This is a change I did to improve the response time of the CLI. |
Ah, yes, now I remember the discussion. |
There is one doc related in the middle. Let me fix it! |
Could you have a look at the failing test? |
In #1657 I propose a change in the CLI to make it more accesible and features more discoverable.
As an example, this pull request converts the showcolortables executable into an esmvaltool subcommand:
Tasks
yamllint
to check that your YAML files do not contain mistakesNew recipe/diagnostic
doc/sphinx/source/recipes
folder and add a new entry to index.rstModified recipe/diagnostic
doc/sphinx/source/recipes
folderNew data reformatting script
Modified data reformatting script
If you need help with any of the tasks above, please do not hesitate to ask by commenting in the issue or pull request.
Closes #issue_number