-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Recipe to reproduce the 2014 KNMI Climate Scenarios (kcs). #1667
Conversation
This is starting a complete re-implementation of the work done here: https://github.com/ESMValGroup/ESMValTool/compare/kcs_script1 The work in that branch is very valuable, but it can benefit much more from the built-in functionality in ESMValTool and -Core.
Update first diagnostic Add outline for second diagnostic
Hi @karinvdwiel, welcome and thanks for the suggestions! I implemented all of them. I attached the updated figure. For the next time, I can show you how to preview the docs on your own computer. |
…sing numpy indexing rather than xarray labelled indexing).
The performance of the second diagnostic scales exponentially with the number of ensemble members for the target model. This led to very long execution time for more than, say, 8 members. I made this step a bit more efficient, which leads to a substantial speedup (~60x). I also discovered a bug when using more than 9 ensemble members, which is now fixed as well. @karinvdwiel, if you are happy with the diagnostic, could you approve the pull request from a scientific point of view? And @bouweandela, could you do a technical check? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I'll continue reviewing tomorrow.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Just some minor suggestions for improvement.
Co-authored-by: Bouwe Andela <b.andela@esciencecenter.nl>
This reverts commit 2ae209f.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You were right @Peter9192, it is indeed a bit more involved to clean up the run_dir. Don't worry about breaking other diagnostics though, the only other Python diagnostic that uses it is esmvaltool/diag_scripts/cvdp/cvdp_wrapper.py
.
Co-authored-by: Bouwe Andela <b.andela@esciencecenter.nl>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mattiarighi Could you please do a final scientific review and test?
@axel-lauer this PR has been waiting for a final round of testing and scientific review (it has already been screened by @karinvdwiel). Is it okay if we merge this, or would you like another review by someone from the scientific team? |
BEEP this is the manual ESMValBot BEEP I've ran the recipe "recipe_kcs.yml" in this branch on the ESMValTool test machine. The output is available here: https://esmvaltool.cloud.dkrz.de/shared/esmvaltool/kcs-test/output/recipe_kcs_20200916_125334 @axel-lauer @karinvdwiel could you have a look at the output and see if this PR is now ready for merge? Thanks! |
Merging this now as a scientific review has been done by @karinvdwiel from KNMI. |
This recipe reproduces the basic steps described in Lenderink 2014, used at the time to produce climate scenario's for the Netherlands. A recent re-implementation of the code lives here, but we figured that porting the code to ESMValTool would make the code more maintainable and sustainable.
An initial attempt at porting the code lives here, but it can benefit much more from the built-in functionality in ESMValTool and -Core. Therefore we decided to start from scratch in this PR, while keeping a link to the older branch for future reference.
Tasks
Create an issue to discuss what you are going to do, if you haven't done so already (and add the link at the bottom)yamllint
to check that your YAML files do not contain mistakesNew recipe/diagnostic
doc/sphinx/source/recipes
folder and add a new entry to index.rst