Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Necessary diagnostic from eyring06jgr for the release of version2 #1686

Merged
merged 123 commits into from Jun 24, 2020

Conversation

hb326
Copy link
Contributor

@hb326 hb326 commented Jun 23, 2020

Before you start, please read our contribution guidelines.

Please discuss your idea with the development team before getting started, to avoid disappointment later. The way to do this is to open a new issue on GitHub. If you are planning to modify an existing functionality, please discuss it with the original author(s) by tagging them in the issue.


Tasks

  • Create an issue to discuss what you are going to do, if you haven't done so already (and add the link at the bottom)
  • Give this pull request a descriptive title that can be used as a one line summary in a changelog
  • Make sure your code is composed of functions of no more than 50 lines and uses meaningful names for variables
  • Circle/CI tests pass. Status can be seen below your pull request. If the tests are failing, click the link to find out why.
  • Preferably Codacy code quality checks pass, however a few remaining hard to solve Codacy issues are still acceptable. Status can be seen below your pull request. If there is an error, click the link to find out why. If you suspect Codacy may be wrong, please ask by commenting.
  • Please use yamllint to check that your YAML files do not contain mistakes
  • (Only if really necessary) Add any additional dependencies needed for the diagnostic script to setup.py, esmvaltool/install/R/r_requirements.txt or esmvaltool/install/Julia/Project.toml (depending on the language of your script) and also to package/meta.yaml for conda dependencies (includes Python and others, but not R/Julia)
  • If new dependencies are introduced, check that the license is compatible with Apache2.0

New recipe/diagnostic

  • Add documentation for the recipe to the doc/sphinx/source/recipes folder and add a new entry to index.rst
  • Add provenance information

Partly addresses #1586 .

irenecionni and others added 30 commits Jun 6, 2019
diagnostics of eyring06 that works in ESMValTool2
file nc output included
final panel b figure 12
final figure1
changes in start end year for climatology
added attributes start and end year
hb326 and others added 3 commits Jun 24, 2020
…p/ESMValTool into version2_eyring06jgr_to_merge

Merge needs to happen since some changes were performed on the git version of this branch that were not pulled into the local version of the branch before other modifications were done.
@hb326
Copy link
Contributor Author

hb326 commented Jun 24, 2020

Tested successfully.
There is only the minor thing with the documentation to fix.

Ok, thanks for testing! The documentation problem should be fixed now.

@mattiarighi
Copy link
Contributor

mattiarighi commented Jun 24, 2020

It's still complaining: I fixed the path, let's see what happens...

@hb326
Copy link
Contributor Author

hb326 commented Jun 24, 2020

It's still complaining: I fixed the path, let's see what happens...

Didn't fix it, I assume. It seems like sphinx cannot find the folder where the figure is located. I had to create the folder new. I have double-checked the name of the figure and the name of the folder in the figure-path, and both are fine. So I am at a loss why there is an error...

@mattiarighi
Copy link
Contributor

mattiarighi commented Jun 24, 2020

Didn't fix it, I assume. It seems like sphinx cannot find the folder where the figure is located. I had to create the folder new. I have double-checked the name of the figure and the name of the folder in the figure-path, and both are fine. So I am at a loss why there is an error...

The path looks correct now, recipe/ was missing.

@hb326
Copy link
Contributor Author

hb326 commented Jun 24, 2020

Didn't fix it, I assume. It seems like sphinx cannot find the folder where the figure is located. I had to create the folder new. I have double-checked the name of the figure and the name of the folder in the figure-path, and both are fine. So I am at a loss why there is an error...

The path looks correct now, recipe/ was missing.

AAAAARRRGGGHHH!
How many times can it still fail us?!

@mattiarighi
Copy link
Contributor

mattiarighi commented Jun 24, 2020

AAAAARRRGGGHHH!

We are getting there 🤞

@hb326
Copy link
Contributor Author

hb326 commented Jun 24, 2020

AAAAARRRGGGHHH!

We are getting there crossed_fingers

It passed!!

@mattiarighi
Copy link
Contributor

mattiarighi commented Jun 24, 2020

🥳 🥳 🥳

M&B 1 - CircleCI 0

@hb326
Copy link
Contributor Author

hb326 commented Jun 24, 2020

partying_face partying_face partying_face

M&B 1 - CircleCI 0

🥳 indeed!
Took us long enough! 😆

@mattiarighi mattiarighi merged commit 24ab544 into master Jun 24, 2020
6 checks passed
High priority issues automation moved this from Review to Done Jun 24, 2020
@mattiarighi mattiarighi deleted the version2_eyring06jgr_to_merge branch Jun 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants