Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pep8-naming errors and fix zmnam diagnostic #1702

Merged
merged 2 commits into from Jul 9, 2020
Merged

Conversation

bouweandela
Copy link
Member

@bouweandela bouweandela commented Jul 6, 2020

Fix pep8-naming errors introduced with the latest version of pep8-naming (can be seen in the failing nightly development test on CircleCI) and fix zmnam diagnostic:

  • Make zmnam work with cartopy 0.18
  • Fix provenance of zmnam

Tasks

  • Give this pull request a descriptive title that can be used as a one line summary in a changelog
  • Circle/CI tests pass. Status can be seen below your pull request. If the tests are failing, click the link to find out why.
  • Preferably Codacy code quality checks pass, however a few remaining hard to solve Codacy issues are still acceptable. Status can be seen below your pull request. If there is an error, click the link to find out why. If you suspect Codacy may be wrong, please ask by commenting.

Make zmnam work with cartopy 0.18

Fix provenance of zmnam
@bouweandela bouweandela requested a review from mattiarighi Jul 6, 2020
@valeriupredoi
Copy link
Contributor

valeriupredoi commented Jul 6, 2020

was just about to ask about those flakey8 tests 🍺

@bouweandela bouweandela added this to the v2.0.0 milestone Jul 8, 2020
@bouweandela bouweandela added the bug label Jul 8, 2020
@mattiarighi mattiarighi merged commit 4507da5 into master Jul 9, 2020
1 check passed
@mattiarighi mattiarighi deleted the pep8-naming branch Jul 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants