Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional features and bugfixes for recipe anav13clim #1723

Merged
merged 5 commits into from Jul 14, 2020
Merged

Conversation

bettina-gier
Copy link
Contributor

@bettina-gier bettina-gier commented Jul 13, 2020

Tasks

  • Create an issue to discuss what you are going to do, if you haven't done so already (and add the link at the bottom)
  • Give this pull request a descriptive title that can be used as a one line summary in a changelog
  • Make sure your code is composed of functions of no more than 50 lines and uses meaningful names for variables
  • Circle/CI tests pass. Status can be seen below your pull request. If the tests are failing, click the link to find out why.
  • Preferably Codacy code quality checks pass, however a few remaining hard to solve Codacy issues are still acceptable. Status can be seen below your pull request. If there is an error, click the link to find out why. If you suspect Codacy may be wrong, please ask by commenting.
  • Please use yamllint to check that your YAML files do not contain mistakes
  • (Only if really necessary) Add any additional dependencies needed for the diagnostic script to setup.py, esmvaltool/install/R/r_requirements.txt or esmvaltool/install/Julia/Project.toml (depending on the language of your script) and also to package/meta.yaml for conda dependencies (includes Python and others, but not R/Julia)
  • If new dependencies are introduced, check that the license is compatible with Apache2.0

Modified recipe/diagnostic

  • Update documentation for the recipe to the doc/sphinx/source/recipes folder

  • Update provenance information if needed

  • Assign the author(s) of the affected recipe(s) as reviewer(s)

  • all diagnostics for anav: check before convert_units that the data is not already in this unit (otherwise error) - application example: tos in CMIP6 has degC cmor unit and degC plot unit

  • evolution plot: Fixed ensemble name from hardcoded "CMIP5" to name given in recipe. Why not simply take project name from data? My application uses the same ensemble but different experiments so wanted easy way to distinguish.

  • removed "legend_year_outside" attribute that isn't used in any diagnostics

bettina-gier and others added 2 commits Jul 14, 2020
Co-authored-by: Mattia Righi <mattia.righi@dlr.de>
Co-authored-by: Mattia Righi <mattia.righi@dlr.de>
@mattiarighi
Copy link
Contributor

mattiarighi commented Jul 14, 2020

esmvalcore._task.DiagnosticError: An error occurred during execution of NCL script carbon_cycle/mvi.ncl, see the log in /mnt/lustre02/work/bd0854/b309057/ESMValTool/v2_output/recipe_anav13jclim_20200714_083603/run/diag_mvi_tas/mvi_global/log.txt

In the diagnostic log:

Variable (all_data_yearly) is still undefined, unable to reference attribute units

@bettina-gier
Copy link
Contributor Author

bettina-gier commented Jul 14, 2020

Are you sure you're using the last version? I had accidentally copy pasted with the wrong variable, but fixed it in a later commit. recipe ran through no problem on mistral last night right before I made the pull request

@mattiarighi
Copy link
Contributor

mattiarighi commented Jul 14, 2020

Yes, sorry, I was missing the last commit.
Trying again.

@mattiarighi mattiarighi merged commit b5c66e9 into master Jul 14, 2020
1 check passed
@mattiarighi mattiarighi deleted the anav_addons branch Jul 14, 2020
@bouweandela bouweandela changed the title Additional features and bugfixes for anav Additional features and bugfixes for recipe anav13clim Aug 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants