Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gmd laueretal2020 revisions #1725

Merged
merged 2 commits into from Jul 14, 2020
Merged

Gmd laueretal2020 revisions #1725

merged 2 commits into from Jul 14, 2020

Conversation

axel-lauer
Copy link
Contributor

@axel-lauer axel-lauer commented Jul 14, 2020

Changes in font size and addition of correlation coefficients to plots created by ecs_scatter.ncl applied during the revsion of Lauer et al. (Geosci. Model Dev. Discuss.), in which these diagnostics are described.

@@ -1515,7 +1519,8 @@ begin

; plot observational uncertainty (if available)

if (isdefined("diagminmax")) then
if (.not.all(ismissing(diagminmax))) then
; if (isdefined("diagminmax")) then
Copy link
Contributor

@mattiarighi mattiarighi Jul 14, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
; if (isdefined("diagminmax")) then

@mattiarighi
Copy link
Contributor

mattiarighi commented Jul 14, 2020

Looks good to me, but maybe @schlunma should test it.

@mattiarighi mattiarighi requested a review from schlunma Jul 14, 2020
Copy link
Contributor

@schlunma schlunma left a comment

Tested successfully, output looks good to me!

@mattiarighi mattiarighi merged commit cfed0d0 into master Jul 14, 2020
6 checks passed
@mattiarighi mattiarighi added this to Done in High priority issues via automation Jul 14, 2020
@mattiarighi mattiarighi deleted the GMD_laueretal2020_revisions branch Jul 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants