Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug in extract_doi_value #1734

Merged
merged 1 commit into from Jul 20, 2020
Merged

Fix bug in extract_doi_value #1734

merged 1 commit into from Jul 20, 2020

Conversation

bascrezee
Copy link
Contributor

Closes #1732

@bascrezee
Copy link
Contributor Author

(failing test is not related to this PR)

@mattiarighi
Copy link
Contributor

Tested successfully.

@SarahAlidoost are you ok with the changes?

@SarahAlidoost
Copy link
Contributor

Tested successfully.

@SarahAlidoost are you ok with the changes?

yes, the changes make sense. Thank you @bascrezee for this fix.

@mattiarighi mattiarighi merged commit a3e7ae8 into master Jul 20, 2020
1 check passed
@mattiarighi mattiarighi deleted the fix-1732 branch July 20, 2020 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattiarighi mattiarighi mattiarighi approved these changes

@SarahAlidoost SarahAlidoost SarahAlidoost approved these changes

Assignees
No one assigned
Labels
bug observations
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cmorizer CDS-SATELLITE-ALBEDO broken
3 participants
@bascrezee @mattiarighi @SarahAlidoost