-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup recipe headers before the release #1740
Conversation
@katjaweigel I renamed |
- ewatercycle | ||
|
||
references: | ||
- sutanudjaja2018gmd |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You lost acknow_project here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Though that is actually not a reference, but a request to acknowledge, so maybe we need to think a bit about how to improve this in the future
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
acknow_project
was introduced for cases where no other references were available, which is not case here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's probably never the case, because all our recipes are based on scientific work, right? Only the example recipes wouldn't have references.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually there are 5 recipes without an actual reference: recipe_consecdrydays.yml
, recipe_ocean_Landschuetzer2016.yml
, recipe_ocean_multimap.yml
, recipe_shapeselect.yml
and recipe_spei.yml
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe references just need to be added?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe yes, but not all our diagnostics are based on published work, or the paper is not yet ready.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be fine to have no reference if no reference is available.
Co-authored-by: Bouwe Andela <b.andela@esciencecenter.nl>
For recipe_spei.yml there are the references vicente10jclim and mckee93proc given inside the two diagnostics it calls. But they are references for the SPEI and SPI indices used, not for the histograms of them plotted by the recipe, this is probably why they are not there at the moment. |
Make recipe headers uniform and fix a few typos.