Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for incomplete months on daily frequency in cmorizer ncl utilities #1754

Merged
merged 1 commit into from Jul 28, 2020

Conversation

mattiarighi
Copy link
Contributor

@mattiarighi mattiarighi commented Jul 23, 2020

Tasks

  • Create an issue to discuss what you are going to do, if you haven't done so already (and add the link at the bottom)
  • Give this pull request a descriptive title that can be used as a one line summary in a changelog
  • Make sure your code is composed of functions of no more than 50 lines and uses meaningful names for variables
  • Circle/CI tests pass. Status can be seen below your pull request. If the tests are failing, click the link to find out why.
  • Preferably Codacy code quality checks pass, however a few remaining hard to solve Codacy issues are still acceptable. Status can be seen below your pull request. If there is an error, click the link to find out why. If you suspect Codacy may be wrong, please ask by commenting.
  • Please use yamllint to check that your YAML files do not contain mistakes
  • (Only if really necessary) Add any additional dependencies needed for the diagnostic script to setup.py, esmvaltool/install/R/r_requirements.txt or esmvaltool/install/Julia/Project.toml (depending on the language of your script) and also to package/meta.yaml for conda dependencies (includes Python and others, but not R/Julia)
  • If new dependencies are introduced, check that the license is compatible with Apache2.0

Modified data reformatting script

  • Test the CMORized data using recipes/example/recipe_check_obs.yml, to make sure the CMOR checks pass without errors
  • Tag @mattiarighi in this pull request, so that the updated dataset can be added to the OBS data pool at DKRZ and synchronized with CEDA-Jasmin

If you need help with any of the tasks above, please do not hesitate to ask by commenting in the issue or pull request.


Closes #1660

@mattiarighi mattiarighi requested a review from bascrezee Jul 23, 2020
@mattiarighi mattiarighi changed the title Fix 1660 Allow for incomplete months on daily frequency in cmorizer ncl utilities Jul 23, 2020
@mattiarighi
Copy link
Contributor Author

mattiarighi commented Jul 23, 2020

I tested it by removing some days at the end of the last month.
If you could also try removing some days at the beginning of the first month it would be great.

@bascrezee
Copy link
Contributor

bascrezee commented Jul 28, 2020

Yes, I can confirm that it works also fine when removing a few days at the start of the data. Thanks!

@mattiarighi
Copy link
Contributor Author

mattiarighi commented Jul 28, 2020

@bouweandela please cherry-pick.

@mattiarighi mattiarighi merged commit 09a9e06 into master Jul 28, 2020
1 check passed
@mattiarighi mattiarighi deleted the fix_1660 branch Jul 28, 2020
@bouweandela
Copy link
Member

bouweandela commented Jul 29, 2020

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

utilities.ncl does not support incomplete years for monthly (and daily?) data
3 participants