Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bug in cmorize_obs_eppley_vgpm_modis.py (#1729) #1759

Merged
merged 5 commits into from Jul 24, 2020
Merged

Conversation

tomaslovato
Copy link
Contributor

@tomaslovato tomaslovato commented Jul 23, 2020

Tasks

  • Create an issue to discuss what you are going to do, if you haven't done so already (and add the link at the bottom)
  • Give this pull request a descriptive title that can be used as a one line summary in a changelog
  • Make sure your code is composed of functions of no more than 50 lines and uses meaningful names for variables
  • Circle/CI tests pass. Status can be seen below your pull request. If the tests are failing, click the link to find out why.
  • Preferably Codacy code quality checks pass, however a few remaining hard to solve Codacy issues are still acceptable. Status can be seen below your pull request. If there is an error, click the link to find out why. If you suspect Codacy may be wrong, please ask by commenting.
  • Please use yamllint to check that your YAML files do not contain mistakes
  • (Only if really necessary) Add any additional dependencies needed for the diagnostic script to setup.py, esmvaltool/install/R/r_requirements.txt or esmvaltool/install/Julia/Project.toml (depending on the language of your script) and also to package/meta.yaml for conda dependencies (includes Python and others, but not R/Julia)
  • If new dependencies are introduced, check that the license is compatible with Apache2.0

Modified data reformatting script

  • Test the CMORized data using recipes/example/recipe_check_obs.yml, to make sure the CMOR checks pass without errors
  • Tag @mattiarighi in this pull request, so that the updated dataset can be added to the OBS data pool at DKRZ and synchronized with CEDA-Jasmin

If you need help with any of the tasks above, please do not hesitate to ask by commenting in the issue or pull request.


Closes #1729

@mattiarighi
Copy link
Contributor

mattiarighi commented Jul 23, 2020

I think you need to add the package also to setup.py, @bouweandela ?

@tomaslovato
Copy link
Contributor Author

tomaslovato commented Jul 23, 2020

I think you need to add the package also to setup.py, @bouweandela ?

I think you are right mattia ...

@mattiarighi
Copy link
Contributor

mattiarighi commented Jul 24, 2020

The installation fails

ERROR: Could not find a version that satisfies the requirement pynio (from ESMValTool==2.0.0b4) (from versions: none)
ERROR: No matching distribution found for pynio (from ESMValTool==2.0.0b4)

which is I guess the same reason why the tests are failing.

@mattiarighi
Copy link
Contributor

mattiarighi commented Jul 24, 2020

Thank you for the fix.

@bouweandela please merge and cherry-pick into v2.0.0-release.

@bouweandela bouweandela merged commit df9d705 into master Jul 24, 2020
1 check passed
@bouweandela bouweandela deleted the fix_1729 branch Jul 24, 2020
bouweandela added a commit that referenced this pull request Jul 24, 2020
* fix bug in cmorize_obs_eppley_vgpm_modis.py (#1729). Added pynio as a dependency.

Co-authored-by: Mattia Righi <mattia.righi@dlr.de>
Co-authored-by: Bouwe Andela <b.andela@esciencecenter.nl>
@bouweandela
Copy link
Member

bouweandela commented Jul 24, 2020

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cmorizer Eppley-VGPM-MODIS broken
3 participants