Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add standard_name attribute to lon and lat in cmorize_obs_esacci_oc.py #1760

Merged
merged 1 commit into from Jul 23, 2020

Conversation

tomaslovato
Copy link
Contributor

@tomaslovato tomaslovato commented Jul 23, 2020

Tasks

  • Create an issue to discuss what you are going to do, if you haven't done so already (and add the link at the bottom)
  • Give this pull request a descriptive title that can be used as a one line summary in a changelog
  • Circle/CI tests pass. Status can be seen below your pull request. If the tests are failing, click the link to find out why.
  • Preferably Codacy code quality checks pass, however a few remaining hard to solve Codacy issues are still acceptable. Status can be seen below your pull request. If there is an error, click the link to find out why. If you suspect Codacy may be wrong, please ask by commenting.

Modified data reformatting script

  • Test the CMORized data using recipes/example/recipe_check_obs.yml, to make sure the CMOR checks pass without errors
  • Tag @mattiarighi in this pull request, so that the updated dataset can be added to the OBS data pool at DKRZ and synchronized with CEDA-Jasmin

If you need help with any of the tasks above, please do not hesitate to ask by commenting in the issue or pull request.


Closes #1730

Copy link
Contributor

@mattiarighi mattiarighi left a comment

Thanks for the quick fix.

@mattiarighi mattiarighi merged commit cf675d3 into master Jul 23, 2020
1 check passed
@mattiarighi mattiarighi deleted the fix_1730 branch Jul 23, 2020
@mattiarighi
Copy link
Contributor

mattiarighi commented Jul 23, 2020

@bouweandela please cherry-pick this in v2.0.0-release.

@bouweandela
Copy link
Member

bouweandela commented Jul 24, 2020

Done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cmorizer ESACCI-OC broken
3 participants