Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix AURA-TES cmorizer #1766

Merged
merged 3 commits into from Jul 29, 2020
Merged

Fix AURA-TES cmorizer #1766

merged 3 commits into from Jul 29, 2020

Conversation

mattiarighi
Copy link
Contributor

@mattiarighi mattiarighi commented Jul 29, 2020

Closes #1176.

Tested successfully with recipe_check_obs.yml.

@mattiarighi
Copy link
Contributor Author

mattiarighi commented Jul 29, 2020

Any suggestion on the failing tests? @bouweandela

Copy link
Contributor

@axel-lauer axel-lauer left a comment

Just tested this cmorizer. Works fine, results look good.

@bouweandela
Copy link
Member

bouweandela commented Jul 29, 2020

The failing tests are because of this: pytest-dev/pytest#7559

@mattiarighi
Copy link
Contributor Author

mattiarighi commented Jul 29, 2020

Now the conda_build complains

@bouweandela
Copy link
Member

bouweandela commented Jul 29, 2020

Let's try also avoiding that pytest version in the conda build.

@bouweandela
Copy link
Member

bouweandela commented Jul 29, 2020

Now the conda build is failing because it ran out of memory on the CircleCI machine, it completed successfully when I run it locally.

@bouweandela bouweandela merged commit 5fb7bfa into master Jul 29, 2020
1 check passed
@bouweandela bouweandela deleted the fix_aura_tes branch Jul 29, 2020
@mattiarighi
Copy link
Contributor Author

mattiarighi commented Jul 29, 2020

Great, thanks!

bouweandela added a commit that referenced this pull request Jul 29, 2020
* Fix data reading and variable name

* Avoid broken pytest 6.0.0 versions

Co-authored-by: Bouwe Andela <b.andela@esciencecenter.nl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AURA-TES cmorizer not running at DKRZ
3 participants