Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix recipe_correlation.yml #1767

Merged
merged 2 commits into from Jul 30, 2020
Merged

Fix recipe_correlation.yml #1767

merged 2 commits into from Jul 30, 2020

Conversation

bouweandela
Copy link
Member

@bouweandela bouweandela commented Jul 30, 2020

Tasks

  • Create an issue to discuss what you are going to do, if you haven't done so already (and add the link at the bottom)
  • Give this pull request a descriptive title that can be used as a one line summary in a changelog
  • Make sure your code is composed of functions of no more than 50 lines and uses meaningful names for variables
  • Circle/CI tests pass. Status can be seen below your pull request. If the tests are failing, click the link to find out why.
  • Preferably Codacy code quality checks pass, however a few remaining hard to solve Codacy issues are still acceptable. Status can be seen below your pull request. If there is an error, click the link to find out why. If you suspect Codacy may be wrong, please ask by commenting.

Closes #1477

@bouweandela bouweandela requested a review from mattiarighi Jul 30, 2020
@bouweandela bouweandela added this to the v2.0.0 milestone Jul 30, 2020
@mattiarighi mattiarighi mentioned this pull request Jul 30, 2020
158 tasks
@mattiarighi
Copy link
Contributor

mattiarighi commented Jul 30, 2020

Still not running

Traceback (most recent call last):
  File "/mnt/lustre01/pf/b/b309057/ESMValTool/public/esmvaltool/diag_scripts/examples/correlate.py", line 94, in <module>
    main(config)
  File "/mnt/lustre01/pf/b/b309057/ESMValTool/public/esmvaltool/diag_scripts/examples/correlate.py", line 76, in main
    coord = dataset.coord(ref_coord)
  File "/work/bd0080/b309057/SOFTWARE/miniconda3/envs/esmvaltool/lib/python3.8/site-packages/iris/cube.py", line 1497, in coord
    raise iris.exceptions.CoordinateNotFoundError(msg)
iris.exceptions.CoordinateNotFoundError: 'Expected to find exactly 1 air_pressure coordinate, but found none.'

@bouweandela
Copy link
Member Author

bouweandela commented Jul 30, 2020

This happens because the `positive' = 'down' attribute is missing from the cmorized air_pressure coordinate of the ERA-Interim data. This looks like a bug in the ERA-Interim CMORizer.

@bouweandela
Copy link
Member Author

bouweandela commented Jul 30, 2020

Created an issue for that here: #1770

@bouweandela bouweandela merged commit c6f9308 into master Jul 30, 2020
1 check passed
@bouweandela bouweandela deleted the fix_recipe_correlation branch Jul 30, 2020
bouweandela added a commit that referenced this pull request Jul 30, 2020
* Fix crash due to loss of vertical coordinate bounds in extract_levels
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Example recipe recipe_correlation.yml crashes
2 participants