Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct date in output filenames of ERA5 CMORizer recipe #1773

Merged
merged 2 commits into from
Aug 3, 2020
Merged

Correct date in output filenames of ERA5 CMORizer recipe #1773

merged 2 commits into from
Aug 3, 2020

Conversation

bouweandela
Copy link
Member

Fixes #1659, fixes #1731

Tasks

  • Create an issue to discuss what you are going to do, if you haven't done so already (and add the link at the bottom)
  • Give this pull request a descriptive title that can be used as a one line summary in a changelog
  • Make sure your code is composed of functions of no more than 50 lines and uses meaningful names for variables
  • Circle/CI tests pass. Status can be seen below your pull request. If the tests are failing, click the link to find out why.
  • Preferably Codacy code quality checks pass, however a few remaining hard to solve Codacy issues are still acceptable. Status can be seen below your pull request. If there is an error, click the link to find out why. If you suspect Codacy may be wrong, please ask by commenting.

@bouweandela bouweandela requested review from mattiarighi and hb326 July 31, 2020 07:19
hb326
hb326 approved these changes Jul 31, 2020
View reviewed changes
Copy link
Contributor

@hb326 hb326 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just ran the recipe again to cmorize monthly precipitation data from ERA5. The time period in the file name is now correct.

@mattiarighi
Copy link
Contributor

Data pool at DKRZ is updated and tested with recipe_check_obs.yml (also updated).

@mattiarighi
Copy link
Contributor

@bouweandela 🍒 ⛏️

@mattiarighi mattiarighi merged commit e585ae1 into master Aug 3, 2020
@mattiarighi mattiarighi deleted the era5-cmorizer-filenames branch August 3, 2020 09:51
bouweandela added a commit that referenced this pull request Aug 3, 2020
@bouweandela @mattiarighi
Correct date in output filenames of ERA5 CMORizer recipe (#1773)
b0071a7 
* Add correct date in filenames

* Extend check recipe accordingly

Co-authored-by: Mattia Righi <mattia.righi@dlr.de>
@bouweandela
Copy link
Member Author

Done

Peter9192
Peter9192 reviewed Aug 3, 2020
View reviewed changes
Copy link
Contributor

@Peter9192 Peter9192 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Just wonder if we should also make a separate filename for hourly data if we do it like this.

@bouweandela
Copy link
Member Author

Only if we want to save incomplete days

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Peter9192 Peter9192 Peter9192 left review comments

@mattiarighi mattiarighi mattiarighi approved these changes

@hb326 hb326 hb326 approved these changes

@SarahAlidoost SarahAlidoost Awaiting requested review from SarahAlidoost

Assignees
No one assigned
Labels
bug observations
Projects
None yet
Milestone
No milestone
4 participants
@bouweandela @mattiarighi @Peter9192 @hb326