Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix R installation in WSL #1789

Merged
merged 1 commit into from
Aug 19, 2020
Merged

Fix R installation in WSL #1789

merged 1 commit into from
Aug 19, 2020

Conversation

jvegreg
Copy link
Contributor

@jvegreg jvegreg commented Aug 17, 2020

There is some problem with staged installation ( https://developer.r-project.org/Blog/public/2019/02/14/staged-install/) in WSL

This pull request deactivates this method of installation

Tasks

  • Create an issue to discuss what you are going to do, if you haven't done so already (and add the link at the bottom)
  • Give this pull request a descriptive title that can be used as a one line summary in a changelog
  • Make sure your code is composed of functions of no more than 50 lines and uses meaningful names for variables
  • Circle/CI tests pass. Status can be seen below your pull request. If the tests are failing, click the link to find out why.
  • Preferably Codacy code quality checks pass, however a few remaining hard to solve Codacy issues are still acceptable. Status can be seen below your pull request. If there is an error, click the link to find out why. If you suspect Codacy may be wrong, please ask by commenting.
  • Please use yamllint to check that your YAML files do not contain mistakes
  • (Only if really necessary) Add any additional dependencies needed for the diagnostic script to setup.py, esmvaltool/install/R/r_requirements.txt or esmvaltool/install/Julia/Project.toml (depending on the language of your script) and also to package/meta.yaml for conda dependencies (includes Python and others, but not R/Julia)
  • If new dependencies are introduced, check that the license is compatible with Apache2.0

Closes ESMValGroup/ESMValTool_Tutorial#115

@bouweandela
Copy link
Member

@stefsmeets Could you please check if this works for you, since you're also into WSL?

@stefsmeets
Copy link
Contributor

stefsmeets commented Aug 17, 2020

Hi @bouweandela , I actually just updated to WSL 2 (part of Windows 2004) this morning and on a fresh Ubuntu distro the installation is working as expected (i.e. the fix is not necessary for WSL 2).

@stefsmeets
Copy link
Contributor

stefsmeets commented Aug 18, 2020

Just tested on WSL 1, and the fix seems to work :-) The installation passes without errors.

@bouweandela bouweandela merged commit 5d9345b into master Aug 19, 2020
@bouweandela bouweandela deleted the fix_r_install branch August 19, 2020 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Installation issues on WSL
3 participants