Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid autodocsumm 0.2.0 and update documentation build dependencies #1794

Merged
merged 1 commit into from Aug 26, 2020

Conversation

bouweandela
Copy link
Member

@bouweandela bouweandela commented Aug 24, 2020

Closes #1793. I also updated the dependencies needed for building the documentation so they match what is in setup.py.


Tasks

  • Create an issue to discuss what you are going to do, if you haven't done so already (and add the link at the bottom)
  • Give this pull request a descriptive title that can be used as a one line summary in a changelog
  • Circle/CI tests pass. Status can be seen below your pull request. If the tests are failing, click the link to find out why.
  • Preferably Codacy code quality checks pass, however a few remaining hard to solve Codacy issues are still acceptable. Status can be seen below your pull request. If there is an error, click the link to find out why. If you suspect Codacy may be wrong, please ask by commenting.
  • Documenation builds on readthedocs

@bouweandela bouweandela marked this pull request as ready for review August 24, 2020 13:51
Copy link
Contributor

@stefsmeets stefsmeets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this on #1648 and the documentation now builds correctly. I can't say much about the added dependencies.

@bouweandela bouweandela merged commit 0421b1c into master Aug 26, 2020
1 check passed
@bouweandela bouweandela deleted the doc branch August 26, 2020 09:25
@bouweandela
Copy link
Member Author

@stefsmeets Thanks for reviewing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Summaries in API not building correctly with autodocsumm 0.2.0
2 participants