Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more info on documenting a recipe #1795

Merged
merged 2 commits into from
Oct 9, 2020
Merged

Add more info on documenting a recipe #1795

merged 2 commits into from
Oct 9, 2020

Conversation

bouweandela
Copy link
Member

@bouweandela bouweandela commented Aug 24, 2020 •
edited
Loading

Add more info on how to document a recipe.

Tasks

  • Give this pull request a descriptive title that can be used as a one line summary in a changelog
  • Circle/CI tests pass. Status can be seen below your pull request. If the tests are failing, click the link to find out why.
  • Preferably Codacy code quality checks pass, however a few remaining hard to solve Codacy issues are still acceptable. Status can be seen below your pull request. If there is an error, click the link to find out why. If you suspect Codacy may be wrong, please ask by commenting.

@bouweandela bouweandela mentioned this pull request Sep 24, 2020
Closed
@bouweandela bouweandela removed the request for review from mattiarighi October 9, 2020 10:59
stefsmeets
stefsmeets approved these changes Oct 9, 2020
View reviewed changes
Copy link
Contributor

@stefsmeets stefsmeets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@bouweandela bouweandela merged commit a7dfd0e into master Oct 9, 2020
@bouweandela bouweandela deleted the recipe-doc branch October 9, 2020 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Peter9192 Peter9192 Peter9192 left review comments

@stefsmeets stefsmeets stefsmeets approved these changes

@valeriupredoi valeriupredoi Awaiting requested review from valeriupredoi

Assignees
No one assigned
Labels
documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bouweandela @stefsmeets @Peter9192