Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move pre-commit excludes to top-level and correct order of lintr and styler #1805

Merged
merged 4 commits into from
Sep 7, 2020
Merged

Move pre-commit excludes to top-level and correct order of lintr and styler #1805

merged 4 commits into from
Sep 7, 2020

Conversation

stefsmeets
Copy link
Contributor

@stefsmeets stefsmeets commented Sep 4, 2020 •
edited by bouweandela
Loading

This patch makes the excludes in the pre-commit config global instead of per repo and runs styler before lintr.

Tasks

  • Give this pull request a descriptive title that can be used as a one line summary in a changelog
  • Circle/CI tests pass. Status can be seen below your pull request. If the tests are failing, click the link to find out why.
  • Preferably Codacy code quality checks pass, however a few remaining hard to solve Codacy issues are still acceptable. Status can be seen below your pull request. If there is an error, click the link to find out why. If you suspect Codacy may be wrong, please ask by commenting.
  • Please use yamllint to check that your YAML files do not contain mistakes

@stefsmeets stefsmeets changed the title Move excludes to top-level Move pre-commit excludes to top-level Sep 4, 2020
@stefsmeets stefsmeets marked this pull request as ready for review September 4, 2020 07:35
bouweandela
bouweandela requested changes Sep 4, 2020
View reviewed changes
Copy link
Member

@bouweandela bouweandela left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for getting this fixed!

.pre-commit-config.yaml Outdated Show resolved Hide resolved
.pre-commit-config.yaml Outdated Show resolved Hide resolved
@stefsmeets stefsmeets self-assigned this Sep 4, 2020
@stefsmeets stefsmeets mentioned this pull request Sep 7, 2020
Merged
4 tasks
bouweandela
bouweandela approved these changes Sep 7, 2020
View reviewed changes
Copy link
Member

@bouweandela bouweandela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bouweandela bouweandela changed the title Move pre-commit excludes to top-level Move pre-commit excludes to top-level and correct order of lintr and styler Sep 7, 2020
@bouweandela bouweandela merged commit 815dc31 into master Sep 7, 2020
@bouweandela bouweandela deleted the precommit_global_exclude branch September 7, 2020 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bouweandela bouweandela bouweandela approved these changes

Assignees

@stefsmeets stefsmeets

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stefsmeets @bouweandela