Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update esmvaltool run command everywhere in documentation #1820

Merged
merged 3 commits into from Oct 1, 2020
Merged

Conversation

bouweandela
Copy link
Member

@bouweandela bouweandela commented Sep 15, 2020

The command to run esmvaltool was changed some time ago, but there were still some old ways of using it in the documentation. This pull request fixes that and a few spelling mistakes.


Tasks

  • Give this pull request a descriptive title that can be used as a one line summary in a changelog
  • Circle/CI tests pass. Status can be seen below your pull request. If the tests are failing, click the link to find out why.
  • Preferably Codacy code quality checks pass, however a few remaining hard to solve Codacy issues are still acceptable. Status can be seen below your pull request. If there is an error, click the link to find out why. If you suspect Codacy may be wrong, please ask by commenting.

@jvegreg
Copy link
Contributor

jvegreg commented Sep 18, 2020

I have found another reference in esmvaltool/diag_scripts/thermodyn_diagtool/thermodyn_diagnostics.py

For some reason, @ValerioLembo put there a small tutorial. I think this is no longer needed, at least in its actual form

@bouweandela
Copy link
Member Author

Thanks for reviewing @jvegasbsc! I have updated the tutorial by @ValerioLembo so it uses the most recent run command. Could you please have another look?

Indeed I think that extra tutorial in a diagnostic is probably not needed, but I'll leave changing that to @ValerioLembo in a different pull request if he feels the need to change it.

jvegreg
jvegreg approved these changes Oct 1, 2020
@jvegreg
Copy link
Contributor

jvegreg commented Oct 1, 2020

The documentation test is failing, but that's because a file you did not touch. I Think this is OK to merge, no?

@bouweandela
Copy link
Member Author

I created an issue for the failing documentation build: Chilipp/autodocsumm#32. For now I'll just change the imports from from itertools import product to import itertools in the affected files, that seems to solve the problem.

@bouweandela bouweandela merged commit ba34f4a into master Oct 1, 2020
7 checks passed
@bouweandela bouweandela deleted the doc branch October 1, 2020 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants