Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ESMValCore v2.1.0 requirement #1839

Merged
merged 3 commits into from Oct 12, 2020
Merged

Conversation

jvegreg
Copy link
Contributor

@jvegreg jvegreg commented Oct 6, 2020

Update ESMValCore requirement to be able to use 2.1 pre release version

@valeriupredoi
Copy link
Contributor

note the failed installation tests are quite right to fail since esmvalcore is picked up as an environment dependency and installed from conda where we haven't updated the package to 2.1 yet 👍

@hb326
Copy link
Contributor

hb326 commented Oct 6, 2020

Yes, this is helpful!
I wanted to test some recipes and already doubted my abilities to pull a new branch or run the ESMValTool since I got the error message about the ESMValCore settings in the setup.py file...

bouweandela
bouweandela previously requested changes Oct 8, 2020
Copy link
Member

@bouweandela bouweandela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The version would also need to be changed for the conda package, in the file package/meta.yml

@jvegreg
Copy link
Contributor Author

jvegreg commented Oct 8, 2020

The version would also need to be changed for the conda package, in the file package/meta.yml

Done! The environment.yml file is also missing, but I think it makes sense to modify it only after ESMValCore 2.1 is available on conda

@bouweandela bouweandela merged commit f2aec83 into master Oct 12, 2020
6 of 7 checks passed
@bouweandela bouweandela deleted the Update-esmvalcore-version branch October 12, 2020 20:17
@valeriupredoi valeriupredoi changed the title Update ESMValCore requirement Update ESMValCore v 2.1.0 requirement Oct 19, 2020
@valeriupredoi valeriupredoi changed the title Update ESMValCore v 2.1.0 requirement Update ESMValCore v2.1.0 requirement Oct 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants