-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unreviewed autoassess recipes #1840
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bouweandela
approved these changes
Oct 7, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine to me. Did you also want to remove the related code?
no that was some fluke it made its way in the PR for some odd reason, that has been removed by me since ages. Some weird stuff was happening in the morning with my git, must be me not fully awake 😁 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@alistairsellar and myself have not yet scientifically reviewed these Autoassess recipes hence they should not be included in the 2.1 release (even if they somehow made it through to 2.0). We'll have to review them and add them, for now they are in the
all_autoassess_recipes
branchBefore you start, please read our contribution guidelines.
Please discuss your idea with the development team before getting started, to avoid disappointment later. The way to do this is to open a new issue on GitHub. If you are planning to modify an existing functionality, please discuss it with the original author(s) by tagging them in the issue.
Tasks
yamllint
to check that your YAML files do not contain mistakesNew recipe/diagnostic
doc/sphinx/source/recipes
folder and add a new entry to index.rstModified recipe/diagnostic
doc/sphinx/source/recipes
folderNew data reformatting script
Modified data reformatting script
If you need help with any of the tasks above, please do not hesitate to ask by commenting in the issue or pull request.
Closes #issue_number