-
Notifications
You must be signed in to change notification settings - Fork 132
Implementation of ensemble member recognition to the ClimWIP diagnostic #1852
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@lukasbrunner is this ready for review? If so, can you mark it as such and request a review from me? |
okay I changed the processing order a bit. actually the ensemble means should probably only be done just before the weighting. this means that all the intermediate plots still show individual members. the order i had originally led to the mean plots and the plots for the individual variable groups being different. this is probably also the cleanest form thinking forward to the implementation of the perfect model test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @lukasbrunner ,
I had a look at the code. It works, and I think the main approach (combining before the weights, splitting after) is fine. But I had a bit of a hard time understanding all the logic to keep track of which ensemble members are part of which models, and I hope we can make that a bit simpler. I left some comments/suggestions to this effect. Do you think we can use some of that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great now! Just one more small suggestion.
I guess we need a scientific review and a test bot run. @nielsdrost can you call the bot on this recipe? Then @ruthlorenz can use the 'official' output in her scientific check.
Co-authored-by: Peter Kalverla <peter.kalverla@gmx.com>
@esmvalbot recipe_climwip.yml |
Starting recipe recipe_climwip.yml, output will be generated here |
Recipe recipe_climwip.yml ran OK, output has been generated here |
@nielsdrost The bot ran through, can you please push the button :) |
Sorry, my review still hanging. Testing now. Does this now depend on the recipe being set-up correctly as in reading all model names (=datasets) from there?
Would that still be handled correctly? |
Do you mean the order of input? Lets wait for the result, but I think it should be fine. I remember raising this with Peter before and he now calls natsorted on them at some point so the recipe input order should not matter. If you want to be sure you could even put another model in between. (if that is what you were asking?) |
I think it should be fine, because what you're writing in the recipe is just shorthand yaml that will get expanded as soon as ESMValTool starts working with the files. When we read in the data in the diagnostic script, we reconstruct the model+ensemble+experiment name from the metadata provided. This happens here:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested this with a bunch of CMIP6 Models with quite a few ensembles and it does the right thing.
weights.pdf
It would be great if this could get merged for tomorrow. We aim to work on something that depends on it during the workshop :) The bot run though and we have two positive reviews. @bouweandela @nielsdrost Thanks! |
Before you start, please read our contribution guidelines.
Please discuss your idea with the development team before getting started, to avoid disappointment later. The way to do this is to open a new issue on GitHub. If you are planning to modify an existing functionality, please discuss it with the original author(s) by tagging them in the issue.
Tasks
yamllint
to check that your YAML files do not contain mistakesModified recipe/diagnostic
doc/sphinx/source/recipes
folderIf you need help with any of the tasks above, please do not hesitate to ask by commenting in the issue or pull request.
Closes #1849