Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added CMORizer for Scripps-CO2-KUM #1857

Merged
merged 4 commits into from Oct 13, 2020
Merged

Added CMORizer for Scripps-CO2-KUM #1857

merged 4 commits into from Oct 13, 2020

Conversation

schlunma
Copy link
Contributor

@schlunma schlunma commented Oct 13, 2020

This PR addes a CMORizer for co2s of Scripps-CO2-KUM.

@axel-lauer: Could you maybe have a brief look at his and add it to DKRZ? It would be nice to include this in v2.1. Thanks!


Tasks

  • Create an issue to discuss what you are going to do, if you haven't done so already (and add the link at the bottom)
  • Give this pull request a descriptive title that can be used as a one line summary in a changelog
  • Make sure your code is composed of functions of no more than 50 lines and uses meaningful names for variables
  • Circle/CI tests pass. Status can be seen below your pull request. If the tests are failing, click the link to find out why.
  • Preferably Codacy code quality checks pass, however a few remaining hard to solve Codacy issues are still acceptable. Status can be seen below your pull request. If there is an error, click the link to find out why. If you suspect Codacy may be wrong, please ask by commenting.
  • Please use yamllint to check that your YAML files do not contain mistakes
  • (Only if really necessary) Add any additional dependencies needed for the diagnostic script to setup.py, esmvaltool/install/R/r_requirements.txt or esmvaltool/install/Julia/Project.toml (depending on the language of your script) and also to package/meta.yaml for conda dependencies (includes Python and others, but not R/Julia)
  • If new dependencies are introduced, check that the license is compatible with Apache2.0

New data reformatting script

  • Test the CMORized data using recipes/example/recipe_check_obs.yml, to make sure the CMOR checks pass without errors
  • Add the new dataset to the table in the documentation
  • Tag @mattiarighi in this pull request, so that the new dataset can be added to the OBS data pool at DKRZ and synchronized with CEDA-Jasmin

If you need help with any of the tasks above, please do not hesitate to ask by commenting in the issue or pull request.


Related to #1844.

@schlunma schlunma added this to the v2.1.0 milestone Oct 13, 2020
@schlunma schlunma self-assigned this Oct 13, 2020
@schlunma schlunma changed the title Cmorize kumco2 Added CMORizer for Scripps-CO2-KUM Oct 13, 2020
Copy link
Contributor

@axel-lauer axel-lauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks all fine to me. Tests were successful, the new data are now also available at DKRZ.

@schlunma
Copy link
Contributor Author

Awesome, thanks for reviewing @axel-lauer!

@schlunma schlunma merged commit 72e487a into master Oct 13, 2020
7 checks passed
@schlunma schlunma deleted the cmorize_kumco2 branch October 13, 2020 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants