-
Notifications
You must be signed in to change notification settings - Fork 132
Github Actions Build Packages and Deploy tests (conda and PyPi) #1858
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Did you provide GitHub with the required ANACONDA_TOKEN
, test_pypi_password
, and pypi_password
already?
|
||
jobs: | ||
|
||
publish: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider using slightly more descriptive job names
publish: | |
deploy_to_conda: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cheers @stefsmeets - no need to since the job appears as Anaconda Publish/publish
- ideally we'd want shorter names so they don't get truncated in the browser dashboard
- master | ||
|
||
jobs: | ||
build-n-publish: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
build-n-publish: | |
deploy_to_pypi: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here 👍
- name: Set up Python 3.8 | ||
uses: actions/setup-python@v1 | ||
with: | ||
python-version: 3.8 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We support python3.6+, so should we build with 3.6?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the actual build and deployment is always done with the latest supported Python, so no need to test with other older versions 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also - that would mean we'd have to release three different packages _py36.., _py37, _py38...
- we could do that but I reckon it's too much since we'd confuse the users even more 😁 ...
Merging this now, because we need it for the release today. If there's any remaining work to do, it can be done in a new pull request. |
Added conda and PyPi package builds and deployment:
release_2.1
branch--label test
, we'll test withrelease_2.1
branch