Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Github Actions Build Packages and Deploy tests (conda and PyPi) #1858

Merged
merged 7 commits into from Oct 26, 2020

Conversation

valeriupredoi
Copy link
Contributor

@valeriupredoi valeriupredoi commented Oct 14, 2020

Added conda and PyPi package builds and deployment:

  • PyPi builds correctly, see here - untested upload to Test PyPi and PyPi, we'll test with release_2.1 branch
  • conda builds correctly (no verify) here - untested upload to Anaconda cloud with --label test, we'll test with release_2.1 branch

Copy link
Member

@bouweandela bouweandela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Did you provide GitHub with the required ANACONDA_TOKEN, test_pypi_password, and pypi_password already?

.github/workflows/action-pypi-build-and-deploy.yml Outdated Show resolved Hide resolved

jobs:

publish:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider using slightly more descriptive job names

Suggested change
publish:
deploy_to_conda:

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cheers @stefsmeets - no need to since the job appears as Anaconda Publish/publish - ideally we'd want shorter names so they don't get truncated in the browser dashboard

- master

jobs:
build-n-publish:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
build-n-publish:
deploy_to_pypi:

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here 👍

- name: Set up Python 3.8
uses: actions/setup-python@v1
with:
python-version: 3.8
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We support python3.6+, so should we build with 3.6?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the actual build and deployment is always done with the latest supported Python, so no need to test with other older versions 👍

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also - that would mean we'd have to release three different packages _py36.., _py37, _py38... - we could do that but I reckon it's too much since we'd confuse the users even more 😁 ...

@bouweandela
Copy link
Member

Merging this now, because we need it for the release today. If there's any remaining work to do, it can be done in a new pull request.

@bouweandela bouweandela merged commit 669114b into master Oct 26, 2020
5 of 7 checks passed
@bouweandela bouweandela deleted the GA_deployment_tests branch October 26, 2020 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants