Skip to content

Adjust recipe_extract_shape.yml to recent changes in the example diagnostic.py #1880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 22, 2020
Merged

Adjust recipe_extract_shape.yml to recent changes in the example diagnostic.py #1880

merged 2 commits into from
Oct 22, 2020

Conversation

bouweandela
Copy link
Member

@bouweandela bouweandela commented Oct 22, 2020 •
edited
Loading

Adjust examples/recipe_extract_shape.yml to changes in the example diagnostic.py introduced in #1827 and add documentation.

Tasks

  • Create an issue to discuss what you are going to do, if you haven't done so already (and add the link at the bottom)
  • Give this pull request a descriptive title that can be used as a one line summary in a changelog
  • Circle/CI tests pass. Status can be seen below your pull request. If the tests are failing, click the link to find out why.
  • Preferably Codacy code quality checks pass, however a few remaining hard to solve Codacy issues are still acceptable. Status can be seen below your pull request. If there is an error, click the link to find out why. If you suspect Codacy may be wrong, please ask by commenting.
  • Please use yamllint to check that your YAML files do not contain mistakes
  • Update documentation for the recipe to the doc/sphinx/source/recipes folder

Closes #1878

valeriupredoi
valeriupredoi approved these changes Oct 22, 2020
View reviewed changes
Copy link
Contributor

@valeriupredoi valeriupredoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice one @bouweandela 👍 🍺

@bouweandela bouweandela merged commit 5e41ea4 into master Oct 22, 2020
@bouweandela bouweandela deleted the fix-recipe_extract_shape branch October 22, 2020 18:13
@bouweandela bouweandela mentioned this pull request Oct 23, 2020
Open
valeriupredoi pushed a commit that referenced this pull request Oct 26, 2020
@bouweandela @valeriupredoi
Adjust recipe_extract_shape.yml to recent changes in the example diag…
12e0f71 
…nostic.py (#1880)

* Adjust recipe to changes in diagnostic.py
* Update documentation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@valeriupredoi valeriupredoi valeriupredoi approved these changes

@ruthlorenz ruthlorenz Awaiting requested review from ruthlorenz

Assignees
No one assigned
Labels
diagnostic
Projects
None yet
Milestone
No milestone
2 participants
@bouweandela @valeriupredoi