Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin esmvaltool subpackages to the same version and build as the esmvaltool conda package #1899

Merged
merged 1 commit into from
Nov 5, 2020

Conversation

bouweandela
Copy link
Member

@bouweandela bouweandela commented Nov 4, 2020

Fixes #1887 if we also build a new conda package.


Tasks

  • Create an issue to discuss what you are going to do, if you haven't done so already (and add the link at the bottom)
  • Give this pull request a descriptive title that can be used as a one line summary in a changelog
  • Circle/CI tests pass. Status can be seen below your pull request. If the tests are failing, click the link to find out why.
  • Preferably Codacy code quality checks pass, however a few remaining hard to solve Codacy issues are still acceptable. Status can be seen below your pull request. If there is an error, click the link to find out why. If you suspect Codacy may be wrong, please ask by commenting.
  • Please use yamllint to check that your YAML files do not contain mistakes

Copy link
Contributor

@valeriupredoi valeriupredoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is needed, man - the packages are pulled with the latest version, but ok if this ensures it 100% 👍

@bouweandela bouweandela merged commit e15f705 into master Nov 5, 2020
@bouweandela bouweandela deleted the pin-subpackages branch November 5, 2020 15:47
@bouweandela
Copy link
Member Author

Thanks for reviewing!

valeriupredoi pushed a commit that referenced this pull request Dec 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ESMValTool v2.1.0 conda package does not always pull in latest ESMValTool dependencies
2 participants